Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2019-11-25  7:28 Stephen Rothwell
  2019-11-25  7:35 ` Daniel Borkmann
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2019-11-25  7:28 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Alexei Starovoitov, Daniel Borkmann

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Hi Dave,

Commits

  5940c5bf6504 ("selftests, bpftool: Skip the build test if not in tree")
  31f8b8295bb8 ("selftests, bpftool: Set EXIT trap after usage function")
  a89b2cbf71d6 ("tools, bpf: Fix build for 'make -s tools/bpf O=<dir>'")
  a0f17cc6665c ("tools, bpftool: Fix warning on ignored return value for 'read'")
  5d946c5abbaf ("xsk: Fix xsk_poll()'s return type")

are missing a Signed-off-by from their committers.

Presumably because the bpf-next tree has been rebased before asking you
to merge it.  :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2019-11-25  7:28 linux-next: Signed-off-by missing for commits in the net-next tree Stephen Rothwell
@ 2019-11-25  7:35 ` Daniel Borkmann
  0 siblings, 0 replies; 27+ messages in thread
From: Daniel Borkmann @ 2019-11-25  7:35 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Alexei Starovoitov

On 11/25/19 8:28 AM, Stephen Rothwell wrote:
> Hi Dave,
> 
> Commits
> 
>    5940c5bf6504 ("selftests, bpftool: Skip the build test if not in tree")
>    31f8b8295bb8 ("selftests, bpftool: Set EXIT trap after usage function")
>    a89b2cbf71d6 ("tools, bpf: Fix build for 'make -s tools/bpf O=<dir>'")
>    a0f17cc6665c ("tools, bpftool: Fix warning on ignored return value for 'read'")
>    5d946c5abbaf ("xsk: Fix xsk_poll()'s return type")
> 
> are missing a Signed-off-by from their committers.
> 
> Presumably because the bpf-next tree has been rebased before asking you
> to merge it.  :-(

Yep, the tree has been rebased onto net-next in order to avoid an ugly merge
conflict. My maintainer SOB is still there fwiw, but I guess in this situation
would probably have been good add both of ours. Sorry for the trouble.

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2019-08-16 14:10     ` Gerd Rausch
@ 2019-08-16 14:31       ` Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2019-08-16 14:31 UTC (permalink / raw)
  To: Gerd Rausch
  Cc: Andy Grover, David Miller, Networking, Chris Mason,
	Linux Next Mailing List, Linux Kernel Mailing List, Andy Grover,
	Chris Mason

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

Hi all,

On Fri, 16 Aug 2019 07:10:34 -0700 Gerd Rausch <gerd.rausch@oracle.com> wrote:
>
> On 16/08/2019 02.15, Andy Grover wrote:
> > On 8/16/19 3:06 PM, Gerd Rausch wrote:  
> >>
> >> Just added the e-mail addresses I found using a simple "google search",
> >> in order to reach out to the original authors of these commits:
> >> Chris Mason and Andy Grover.
> >>
> >> I'm hoping they still remember their work from 7-8 years ago.  
> > 
> > Yes looks like what I was working on. What did you need from me? It's
> > too late to amend the commitlogs...

Yeah, Dave doesn't rebase his trees.

> I'll let Stephen or David respond to what (if any) action is necessary.
> 
> The missing Signed-off-by was pointed out to me by Stephen yesterday.
> 
> Hence I tried to locate you guys to pull you into the loop in order to
> not leave his concern unanswered.

It is OK for SOBs to be missing, I just wanted to make sure that it was
OK in this instance.  (Its better that I ask when its OK then not to
ask and find something has gone wrong.)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2019-08-16  9:15   ` Andy Grover
  2019-08-16 12:45     ` Chris Mason
@ 2019-08-16 14:10     ` Gerd Rausch
  2019-08-16 14:31       ` Stephen Rothwell
  1 sibling, 1 reply; 27+ messages in thread
From: Gerd Rausch @ 2019-08-16 14:10 UTC (permalink / raw)
  To: Andy Grover, Stephen Rothwell, David Miller, Networking, Chris Mason
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Grover,
	Chris Mason

Hi,

On 16/08/2019 02.15, Andy Grover wrote:
> On 8/16/19 3:06 PM, Gerd Rausch wrote:
>> Hi,
>>
>> Just added the e-mail addresses I found using a simple "google search",
>> in order to reach out to the original authors of these commits:
>> Chris Mason and Andy Grover.
>>
>> I'm hoping they still remember their work from 7-8 years ago.
> 
> Yes looks like what I was working on. What did you need from me? It's
> too late to amend the commitlogs...
> 

I'll let Stephen or David respond to what (if any) action is necessary.

The missing Signed-off-by was pointed out to me by Stephen yesterday.

Hence I tried to locate you guys to pull you into the loop in order to
not leave his concern unanswered.

Thanks,

  Gerd





^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2019-08-16  9:15   ` Andy Grover
@ 2019-08-16 12:45     ` Chris Mason
  2019-08-16 14:10     ` Gerd Rausch
  1 sibling, 0 replies; 27+ messages in thread
From: Chris Mason @ 2019-08-16 12:45 UTC (permalink / raw)
  To: Andy Grover
  Cc: Gerd Rausch, Stephen Rothwell, David Miller, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, Andy Grover,
	Chris Mason

On 16 Aug 2019, at 5:15, Andy Grover wrote:

> On 8/16/19 3:06 PM, Gerd Rausch wrote:
>> Hi,
>>
>> Just added the e-mail addresses I found using a simple "google 
>> search",
>> in order to reach out to the original authors of these commits:
>> Chris Mason and Andy Grover.
>>
>> I'm hoping they still remember their work from 7-8 years ago.
>
> Yes looks like what I was working on. What did you need from me? It's
> too late to amend the commitlogs...

Same question ;)  The missing signed-off-by is a mistake, but from the 
point of view of the DCO, these patches are totally fine by me.

-chris

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2019-08-15 22:06 ` Gerd Rausch
@ 2019-08-16  9:15   ` Andy Grover
  2019-08-16 12:45     ` Chris Mason
  2019-08-16 14:10     ` Gerd Rausch
  0 siblings, 2 replies; 27+ messages in thread
From: Andy Grover @ 2019-08-16  9:15 UTC (permalink / raw)
  To: Gerd Rausch, Stephen Rothwell, David Miller, Networking, Chris Mason
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Grover,
	Chris Mason

On 8/16/19 3:06 PM, Gerd Rausch wrote:
> Hi,
> 
> Just added the e-mail addresses I found using a simple "google search",
> in order to reach out to the original authors of these commits:
> Chris Mason and Andy Grover.
> 
> I'm hoping they still remember their work from 7-8 years ago.

Yes looks like what I was working on. What did you need from me? It's
too late to amend the commitlogs...

-- Andy

> 
> Thanks,
> 
>   Gerd
> 
> On 15/08/2019 14.53, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>   11740ef44829 ("rds: check for excessive looping in rds_send_xmit")
>>   65dedd7fe1f2 ("RDS: limit the number of times we loop in rds_send_xmit")
>>
>> are missing a Signed-off-by from their authors.
>>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2019-08-15 21:53 Stephen Rothwell
@ 2019-08-15 22:06 ` Gerd Rausch
  2019-08-16  9:15   ` Andy Grover
  0 siblings, 1 reply; 27+ messages in thread
From: Gerd Rausch @ 2019-08-15 22:06 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking, Chris Mason, andy
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Grover,
	Chris Mason

Hi,

Just added the e-mail addresses I found using a simple "google search",
in order to reach out to the original authors of these commits:
Chris Mason and Andy Grover.

I'm hoping they still remember their work from 7-8 years ago.

Thanks,

  Gerd

On 15/08/2019 14.53, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   11740ef44829 ("rds: check for excessive looping in rds_send_xmit")
>   65dedd7fe1f2 ("RDS: limit the number of times we loop in rds_send_xmit")
> 
> are missing a Signed-off-by from their authors.
> 

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2019-08-15 21:53 Stephen Rothwell
  2019-08-15 22:06 ` Gerd Rausch
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2019-08-15 21:53 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Grover,
	Gerd Rausch, Chris Mason

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi all,

Commits

  11740ef44829 ("rds: check for excessive looping in rds_send_xmit")
  65dedd7fe1f2 ("RDS: limit the number of times we loop in rds_send_xmit")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-10 13:35       ` Andrew Lunn
@ 2018-12-10 13:55         ` Sabrina Dubroca
  0 siblings, 0 replies; 27+ messages in thread
From: Sabrina Dubroca @ 2018-12-10 13:55 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: David Miller, hkallweit1, sfr, netdev, linux-next, linux-kernel,
	f.fainelli

2018-12-10, 14:35:00 +0100, Andrew Lunn wrote:
> > The problem here is the '--' delimiter, Andrew should have either
> > used nothing or something else.
> 
> I picked -- because it was not --- !
> 
> Anyway, lesson learned. But i kind of expect it will happen again to
> others, since the "Submitting Patches" documentation just mentions ---
> and does not say that other similar markers may also trigger the magic
> scissors.

-- doesn't trigger the scissors. It looks like patchwork replaced your
-- with a ---, as I wrote in my other reply.

-- 
Sabrina

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-10  0:28     ` David Miller
@ 2018-12-10 13:35       ` Andrew Lunn
  2018-12-10 13:55         ` Sabrina Dubroca
  0 siblings, 1 reply; 27+ messages in thread
From: Andrew Lunn @ 2018-12-10 13:35 UTC (permalink / raw)
  To: David Miller
  Cc: hkallweit1, sfr, netdev, linux-next, linux-kernel, f.fainelli

> The problem here is the '--' delimiter, Andrew should have either
> used nothing or something else.

I picked -- because it was not --- !

Anyway, lesson learned. But i kind of expect it will happen again to
others, since the "Submitting Patches" documentation just mentions ---
and does not say that other similar markers may also trigger the magic
scissors.

	Andrew

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-10  0:54             ` David Miller
@ 2018-12-10  2:05               ` Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2018-12-10  2:05 UTC (permalink / raw)
  To: David Miller
  Cc: sd, andrew, hkallweit1, netdev, linux-next, linux-kernel, f.fainelli

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hi Dave,

On Sun, 09 Dec 2018 16:54:43 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 10 Dec 2018 11:48:48 +1100
> 
> > That is fine as a last resort, but it is probably less disruptive to
> > find these things before you try to push i.e. as part of the "apply the
> > patch" otherwise you could end up having to rebase a whole lot of later
> > commits.  
> 
> I meant to imply that we should do both, something I do pre-commit
> and something that double checks again when I push.
> 
> Sorry if I wasn't clear.

No worries, belts and braces :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-10  0:48           ` Stephen Rothwell
@ 2018-12-10  0:54             ` David Miller
  2018-12-10  2:05               ` Stephen Rothwell
  0 siblings, 1 reply; 27+ messages in thread
From: David Miller @ 2018-12-10  0:54 UTC (permalink / raw)
  To: sfr; +Cc: sd, andrew, hkallweit1, netdev, linux-next, linux-kernel, f.fainelli

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 10 Dec 2018 11:48:48 +1100

> That is fine as a last resort, but it is probably less disruptive to
> find these things before you try to push i.e. as part of the "apply the
> patch" otherwise you could end up having to rebase a whole lot of later
> commits.

I meant to imply that we should do both, something I do pre-commit
and something that double checks again when I push.

Sorry if I wasn't clear.

> Anyway, here's my current version of my script.  It just takes a commit
> range (anything you can pass to "git log").  You may want to drop the
> gitk invocation at the end.

Thanks!

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-10  0:31         ` David Miller
@ 2018-12-10  0:48           ` Stephen Rothwell
  2018-12-10  0:54             ` David Miller
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2018-12-10  0:48 UTC (permalink / raw)
  To: David Miller
  Cc: sd, andrew, hkallweit1, netdev, linux-next, linux-kernel, f.fainelli

[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]

Hi Dave,

On Sun, 09 Dec 2018 16:31:52 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Sabrina Dubroca <sd@queasysnail.net>
> Date: Mon, 10 Dec 2018 00:27:22 +0100
> 
> > Maybe Stephen's script to detect those missing sign-offs could be run
> > as a commit/apply hook by David? This happens regularly, sometimes
> > dropping more than just a sign-off.  
> 
> Yeah, that would probably be a good idea, maybe something even on the
> git.kernel.org side that won't let me push if I'm sending commits that
> have this problem.

That is fine as a last resort, but it is probably less disruptive to
find these things before you try to push i.e. as part of the "apply the
patch" otherwise you could end up having to rebase a whole lot of later
commits.

Anyway, here's my current version of my script.  It just takes a commit
range (anything you can pass to "git log").  You may want to drop the
gitk invocation at the end.

--------------------------------------------------------------------
#!/bin/bash

if [ "$#" -lt 1 ]; then
	printf "Usage: %s <commit range>\n", "$0" 1>&2
	exit 1
fi

commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
	printf "No commits\n"
	exit 0
fi

author_missing=
committer_missing=

print_commits()
{
	local t="$1"

	shift

	s=
	is='is'
	its='its'
	[ "$#" -gt 1 ] && {
		s='s'
		is='are'
		its='their'
	}
	printf "Commit%s\n\n" "$s"
	git log --no-walk --pretty='format:  %h ("%s")' "$@"
	printf "\n%s missing a Signed-off-by from %s %s%s.\n" "$is" "$its" "$t" "$s"
	printf "\n"
}

for c in $commits; do
	ae=$(git log -1 --format='<%ae>%n<%aE>%n %an %n %aN ' "$c" | sort -u)
	ce=$(git log -1 --format='<%ce>%n<%cE>%n %cn %n %cN ' "$c" | sort -u)
	msg=$(git log -1 --format='%b' "$c")
	sob=$(echo "$msg" | sed -En 's/^\s*Signed-off-by:?\s*/ /ip')

	am=false
	cm=false
	grep -i -F -q "$ae" <<<"$sob" ||
		am=true
	grep -i -F -q "$ce" <<<"$sob" ||
		cm=true
	"$am" && author_missing+=" $c"
	"$cm" && committer_missing+=" $c"
done

if [ "$author_missing" ]; then
	print_commits "author" $author_missing
fi
if [ "$committer_missing" ]; then
	print_commits "committer" $committer_missing
fi

exec gitk "$@"
--------------------------------------------------------------------

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 23:27       ` Sabrina Dubroca
@ 2018-12-10  0:31         ` David Miller
  2018-12-10  0:48           ` Stephen Rothwell
  0 siblings, 1 reply; 27+ messages in thread
From: David Miller @ 2018-12-10  0:31 UTC (permalink / raw)
  To: sd; +Cc: andrew, hkallweit1, sfr, netdev, linux-next, linux-kernel, f.fainelli

From: Sabrina Dubroca <sd@queasysnail.net>
Date: Mon, 10 Dec 2018 00:27:22 +0100

> Maybe Stephen's script to detect those missing sign-offs could be run
> as a commit/apply hook by David? This happens regularly, sometimes
> dropping more than just a sign-off.

Yeah, that would probably be a good idea, maybe something even on the
git.kernel.org side that won't let me push if I'm sending commits that
have this problem.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 21:33   ` Heiner Kallweit
  2018-12-09 21:49     ` Andrew Lunn
@ 2018-12-10  0:28     ` David Miller
  2018-12-10 13:35       ` Andrew Lunn
  1 sibling, 1 reply; 27+ messages in thread
From: David Miller @ 2018-12-10  0:28 UTC (permalink / raw)
  To: hkallweit1; +Cc: andrew, sfr, netdev, linux-next, linux-kernel, f.fainelli

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 9 Dec 2018 22:33:10 +0100

> On 09.12.2018 22:11, Andrew Lunn wrote:
>> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>>>
>>> are missing a Signed-off-by from their author.
>> 
>> Hi David.
>> 
>> Any idea what happened here? The version in my git repo has SOB.
>> 
>> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
>> 
> Instead of
> v2
> --
> int -> u32 in platform data structure
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> shouldn't it be
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v2
> - int -> u32 in platform data structure

No, I want the changelog to actually appear in the commit message.

I'm kinda tired of saying this.

Keep changelog information in the commit message, everyone.

The problem here is the '--' delimiter, Andrew should have either
used nothing or something else.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 21:11 ` Andrew Lunn
  2018-12-09 21:33   ` Heiner Kallweit
@ 2018-12-10  0:27   ` David Miller
  1 sibling, 0 replies; 27+ messages in thread
From: David Miller @ 2018-12-10  0:27 UTC (permalink / raw)
  To: andrew; +Cc: sfr, netdev, linux-next, linux-kernel, f.fainelli

From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 9 Dec 2018 22:11:39 +0100

> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Commits
>> 
>>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>> 
>> are missing a Signed-off-by from their author.
> 
> Hi David.
> 
> Any idea what happened here? The version in my git repo has SOB.
> 
> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.

I wonder if "git am" ate it. :-/

Yeah it's the '--' I think.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 21:49     ` Andrew Lunn
@ 2018-12-09 23:27       ` Sabrina Dubroca
  2018-12-10  0:31         ` David Miller
  0 siblings, 1 reply; 27+ messages in thread
From: Sabrina Dubroca @ 2018-12-09 23:27 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Heiner Kallweit, David Miller, Stephen Rothwell, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List,
	Florian Fainelli

2018-12-09, 22:49:07 +0100, Andrew Lunn wrote:
> On Sun, Dec 09, 2018 at 10:33:10PM +0100, Heiner Kallweit wrote:
> > On 09.12.2018 22:11, Andrew Lunn wrote:
> > > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
> > >> Hi all,
> > >>
> > >> Commits
> > >>
> > >>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
> > >>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
> > >>
> > >> are missing a Signed-off-by from their author.
> > > 
> > > Hi David.
> > > 
> > > Any idea what happened here? The version in my git repo has SOB.
> > > 
> > > https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
> > > 
> > Instead of
> > v2
> > --
> > int -> u32 in platform data structure
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > 
> > shouldn't it be
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > v2
> > - int -> u32 in platform data structure
> 
> Hi Heiner
> 
> David said he wanted to see the version history. So i deliberately put
> it above the ---.
> 
> I'm just wondering if -- was enough to trigger something in David's
> scripts? Or patchwork. The -- has disappeared in the commit which made
> it into net-next.
> 
>    Andrew

If you fetch the mbox from patchwork at

    https://patchwork.ozlabs.org/patch/1009811/mbox/

it contains:

-------- 8< --------
v2
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
int -> u32 in platform data structure

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
[diffstat]
-------- 8< --------

That's 3 dashes instead of the 2 from your mail. If you "git am" that,
the sign-off and actual history will get chopped off.

Maybe Stephen's script to detect those missing sign-offs could be run
as a commit/apply hook by David? This happens regularly, sometimes
dropping more than just a sign-off.

-- 
Sabrina

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 21:33   ` Heiner Kallweit
@ 2018-12-09 21:49     ` Andrew Lunn
  2018-12-09 23:27       ` Sabrina Dubroca
  2018-12-10  0:28     ` David Miller
  1 sibling, 1 reply; 27+ messages in thread
From: Andrew Lunn @ 2018-12-09 21:49 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: David Miller, Stephen Rothwell, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List,
	Florian Fainelli

On Sun, Dec 09, 2018 at 10:33:10PM +0100, Heiner Kallweit wrote:
> On 09.12.2018 22:11, Andrew Lunn wrote:
> > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Commits
> >>
> >>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
> >>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
> >>
> >> are missing a Signed-off-by from their author.
> > 
> > Hi David.
> > 
> > Any idea what happened here? The version in my git repo has SOB.
> > 
> > https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
> > 
> Instead of
> v2
> --
> int -> u32 in platform data structure
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> shouldn't it be
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v2
> - int -> u32 in platform data structure

Hi Heiner

David said he wanted to see the version history. So i deliberately put
it above the ---.

I'm just wondering if -- was enough to trigger something in David's
scripts? Or patchwork. The -- has disappeared in the commit which made
it into net-next.

   Andrew

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 21:11 ` Andrew Lunn
@ 2018-12-09 21:33   ` Heiner Kallweit
  2018-12-09 21:49     ` Andrew Lunn
  2018-12-10  0:28     ` David Miller
  2018-12-10  0:27   ` David Miller
  1 sibling, 2 replies; 27+ messages in thread
From: Heiner Kallweit @ 2018-12-09 21:33 UTC (permalink / raw)
  To: Andrew Lunn, David Miller
  Cc: Stephen Rothwell, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Florian Fainelli

On 09.12.2018 22:11, Andrew Lunn wrote:
> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>>
>> are missing a Signed-off-by from their author.
> 
> Hi David.
> 
> Any idea what happened here? The version in my git repo has SOB.
> 
> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
> 
Instead of
v2
--
int -> u32 in platform data structure

Signed-off-by: Andrew Lunn <andrew@lunn.ch>

shouldn't it be

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
v2
- int -> u32 in platform data structure

?

Heiner
>      Thanks
> 	Andrew
> 

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-12-09 21:00 Stephen Rothwell
@ 2018-12-09 21:11 ` Andrew Lunn
  2018-12-09 21:33   ` Heiner Kallweit
  2018-12-10  0:27   ` David Miller
  0 siblings, 2 replies; 27+ messages in thread
From: Andrew Lunn @ 2018-12-09 21:11 UTC (permalink / raw)
  To: David Miller
  Cc: Stephen Rothwell, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Florian Fainelli

On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
> 
> are missing a Signed-off-by from their author.

Hi David.

Any idea what happened here? The version in my git repo has SOB.

https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.

     Thanks
	Andrew

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2018-12-09 21:00 Stephen Rothwell
  2018-12-09 21:11 ` Andrew Lunn
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2018-12-09 21:00 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andrew Lunn,
	Florian Fainelli

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Hi all,

Commits

  dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
  04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2018-10-19  7:30 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2018-10-19  7:30 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hi all,

Commits

  2a4c42980250 ("net/mlx5: Remove counter from idr after removing it from list")
  fd3307130344 ("net/mlx5: Take fs_counters dellist before addlist")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-04-02  5:38 ` Johan Hedberg
@ 2018-04-02  6:50   ` Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2018-04-02  6:50 UTC (permalink / raw)
  To: Johan Hedberg
  Cc: David Miller, Networking, Linux-Next Mailing List,
	Linux Kernel Mailing List, Marcel Holtmann

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Hi Johan,

On Mon, 2 Apr 2018 08:38:03 +0300 Johan Hedberg <johan.hedberg@intel.com> wrote:
>
> On Mon, Apr 02, 2018, Stephen Rothwell wrote:
> >   45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4")
> >   f9b95db0165a ("Bluetooth: btrsi: remove unused including <linux/version.h>")
> >   96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME")
> >   9ea471320e13 ("Bluetooth: Mark expected switch fall-throughs")
> > 
> > are missing a Signed-off-by from their committer.  
> 
> I think this is because I fixed up a missing author name in "Bluetooth:
> hci_bcm: Remove DMI quirk for the MINIX Z83-4" and did a push --force,
> whereas these patches were originally committed by Marcel. Should I be
> adding my signed-off-by to all affected patches when doing such rebases?

Yep, Ideally we should have a Signed-off-by from everyone who involved
in getting the patches into the final tree.  That definitely means that
the final committer needs to add one.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Signed-off-by missing for commits in the net-next tree
  2018-04-02  2:30 Stephen Rothwell
@ 2018-04-02  5:38 ` Johan Hedberg
  2018-04-02  6:50   ` Stephen Rothwell
  0 siblings, 1 reply; 27+ messages in thread
From: Johan Hedberg @ 2018-04-02  5:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux-Next Mailing List,
	Linux Kernel Mailing List, Marcel Holtmann

Hi,

On Mon, Apr 02, 2018, Stephen Rothwell wrote:
>   45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4")
>   f9b95db0165a ("Bluetooth: btrsi: remove unused including <linux/version.h>")
>   96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME")
>   9ea471320e13 ("Bluetooth: Mark expected switch fall-throughs")
> 
> are missing a Signed-off-by from their committer.

I think this is because I fixed up a missing author name in "Bluetooth:
hci_bcm: Remove DMI quirk for the MINIX Z83-4" and did a push --force,
whereas these patches were originally committed by Marcel. Should I be
adding my signed-off-by to all affected patches when doing such rebases?

Johan

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2018-04-02  2:30 Stephen Rothwell
  2018-04-02  5:38 ` Johan Hedberg
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2018-04-02  2:30 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Johan Hedberg, Marcel Holtmann

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

Commits

  45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4")
  f9b95db0165a ("Bluetooth: btrsi: remove unused including <linux/version.h>")
  96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME")
  9ea471320e13 ("Bluetooth: Mark expected switch fall-throughs")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2018-03-02  4:52 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2018-03-02  4:52 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

Commits

  568477045f80 (" phy: marvell10g: Utilize gen10g_no_soft_reset()")
  0adfdb667ab5 (" phy: cortina: Utilize generic functions")
  aebc78a40b88 (" phy: teranetics: Utilize generic functions")
  e8a714e086e4 (" phy: Export gen10g_* functions")
  6ed33d3a06e6 (" phy: aquantia: Utilize genphy_c45_aneg_done()")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Signed-off-by missing for commits in the net-next tree
@ 2017-12-18 20:41 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2017-12-18 20:41 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Bert Kenward,
	Edward Cree

Hi all,

Commits

  d8d8ccf27741 ("sfc: update EF10 register definitions")
  0bc959a95e8c ("sfc: populate the timer reload field")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, back to index

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25  7:28 linux-next: Signed-off-by missing for commits in the net-next tree Stephen Rothwell
2019-11-25  7:35 ` Daniel Borkmann
  -- strict thread matches above, loose matches on Subject: below --
2019-08-15 21:53 Stephen Rothwell
2019-08-15 22:06 ` Gerd Rausch
2019-08-16  9:15   ` Andy Grover
2019-08-16 12:45     ` Chris Mason
2019-08-16 14:10     ` Gerd Rausch
2019-08-16 14:31       ` Stephen Rothwell
2018-12-09 21:00 Stephen Rothwell
2018-12-09 21:11 ` Andrew Lunn
2018-12-09 21:33   ` Heiner Kallweit
2018-12-09 21:49     ` Andrew Lunn
2018-12-09 23:27       ` Sabrina Dubroca
2018-12-10  0:31         ` David Miller
2018-12-10  0:48           ` Stephen Rothwell
2018-12-10  0:54             ` David Miller
2018-12-10  2:05               ` Stephen Rothwell
2018-12-10  0:28     ` David Miller
2018-12-10 13:35       ` Andrew Lunn
2018-12-10 13:55         ` Sabrina Dubroca
2018-12-10  0:27   ` David Miller
2018-10-19  7:30 Stephen Rothwell
2018-04-02  2:30 Stephen Rothwell
2018-04-02  5:38 ` Johan Hedberg
2018-04-02  6:50   ` Stephen Rothwell
2018-03-02  4:52 Stephen Rothwell
2017-12-18 20:41 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git