From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7304EC4338F for ; Wed, 18 Aug 2021 17:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DD18610CE for ; Wed, 18 Aug 2021 17:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229533AbhHRRgd (ORCPT ); Wed, 18 Aug 2021 13:36:33 -0400 Received: from mxout03.lancloud.ru ([45.84.86.113]:59042 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhHRRgc (ORCPT ); Wed, 18 Aug 2021 13:36:32 -0400 X-Greylist: delayed 422 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Aug 2021 13:36:31 EDT Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 1B4DC207445A Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: linux-next: Fixes tag needs some work in the i2c tree To: Stephen Rothwell , Wolfram Sang CC: Linux Kernel Mailing List , "Linux Next Mailing List" References: <20210818074903.2da12b1f@canb.auug.org.au> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <42b3cebf-de30-5677-f98b-7a59543a3004@omp.ru> Date: Wed, 18 Aug 2021 20:28:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210818074903.2da12b1f@canb.auug.org.au> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 8/18/21 12:49 AM, Stephen Rothwell wrote: [...] > In commit > > fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check") > > Fixes tag > > Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.") > > has these problem(s): > > - SHA1 should be at least 12 digits long > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 > or later) just making sure it is not set (or set to "auto"). > - Subject does not match target commit subject > Just use > git log -1 --format='Fixes: %h ("%s")' > So: > > Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller") Sorry for this copypaste blunder. :-/ > Or maybe you meant: > > Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.") Yes, this one looks more correct. Wolfram, what should we do now? MBR, Sergei