From: "Rafael J. Wysocki" <firstname.lastname@example.org> To: Stephen Rothwell <email@example.com> Cc: Linux Next Mailing List <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com>, Andy Shevchenko <firstname.lastname@example.org>, Mika Westerberg <email@example.com> Subject: Re: linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Date: Tue, 15 Oct 2019 12:04:08 +0200 Message-ID: <4823987.OjxUhv8yZC@kreacher> (raw) In-Reply-To: <firstname.lastname@example.org> On Tuesday, October 15, 2019 1:16:50 AM CEST Stephen Rothwell wrote: > > --Sig_/6GS1h5au_w04qPbsgg/ztsa > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > Hi all, > > On Tue, 15 Oct 2019 10:08:55 +1100 Stephen Rothwell <email@example.com> = > wrote: > > > > After merging the pm tree, today's linux-next build (arm > > multi_v7_defconfig) produced this warning: > >=20 > > In file included from include/linux/irqchip.h:14, > > from arch/arm/kernel/irq.c:26: > > include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared insid= > e parameter list will not be visible outside of this definition or declarat= > ion > > 682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2= > , const char *uid2) > > | ^~~~~~~~~~~ > >=20 > > and many more. > >=20 > > Introduced by commit > >=20 > > d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper") > >=20 > > CONFIG_ACPI is not set for this build. > > This became a build failure for the powerpc ppc64_allmodconfig build: > > In file included from include/linux/i2c.h:13, > from arch/powerpc/platforms/pasemi/misc.c:14: > include/linux/acpi.h:682:31: error: 'struct acpi_device' declared inside pa= > rameter list will not be visible outside of this definition or declaration = > [-Werror] > 682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, = > const char *uid2) > | ^~~~~~~~~~~ > cc1: all warnings being treated as errors > > (and many more) > > I have used the pm tree from next-20191014 for today. So this looks weird, because there is an acpi_dev_put() stub in include/linux/acpi.h too in the same #else block and it takes a (struct acpi_device *) pointer too and it has not been touched by the commit in question. So why has it built successfully so far? Also I wonder why 0-day didn't warn about that commit. Anyway, I've added an extra declaration of struct acpi_device to the #else block in question to suppress the warning(s).
next prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-14 23:08 linux-next: build warning after merge of the pm tree Stephen Rothwell 2019-10-14 23:16 ` linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Stephen Rothwell 2019-10-15 10:04 ` Rafael J. Wysocki [this message] 2019-10-16 9:15 ` Geert Uytterhoeven 2019-10-16 9:33 ` Andy Shevchenko 2019-10-15 8:23 ` linux-next: build warning after merge of the pm tree Andy Shevchenko 2019-10-15 9:41 ` Rafael J. Wysocki
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4823987.OjxUhv8yZC@kreacher \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Next Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \ firstname.lastname@example.org public-inbox-index linux-next Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next AGPL code for this site: git clone https://public-inbox.org/public-inbox.git