linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: randy.dunlap@oracle.com, lenb@kernel.org,
	linux-acpi@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath()
Date: Wed, 02 Jul 2008 23:07:25 +0200	[thread overview]
Message-ID: <486BEE0D.3030901@firstfloor.org> (raw)
In-Reply-To: <20080702140216.334011a4.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Wed, 02 Jul 2008 22:51:52 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
> 
>>> If you really want to do it this way (and it sounds reasonable) then
>>> can we please do it in a less-than-totally-hacky-and-broken way?
>>>
>>>
>>>
>>> For example, define a new, always-available helper function in (say)
>>> kernel/panic.c along the lines of
>>>
>>> void emit_warning_message(?)(const char *msg, int line)
>>
>> Ok we can just rename warn_on_slow_path() which is already there to that new name.
> 
> Sure, that'd work.  But we should pull it outside any ifdefs so that it
> is always available (IMO).

For !CONFIG_BUG it's reasonable to not have the calls. These people
who define it must be fighting for every byte ... So i think
the stub inline in my previous patch is fine.

What name do you want?

-Andi

  reply	other threads:[~2008-07-02 21:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080701103339.b5acc1f3.randy.dunlap@oracle.com>
     [not found] ` <20080701131714.5093fa49.akpm@linux-foundation.org>
     [not found]   ` <23433248.1214943818230.JavaMail.oracle@acsmt302.oracle.com>
     [not found]     ` <20080701133535.f92a673c.akpm@linux-foundation.org>
2008-07-02 18:28       ` [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath() Randy Dunlap
2008-07-02 18:50         ` Andi Kleen
2008-07-02 19:14           ` Andrew Morton
2008-07-02 19:31             ` Andi Kleen
2008-07-02 19:43               ` Andrew Morton
2008-07-02 20:11                 ` Andi Kleen
2008-07-02 20:35                   ` Andrew Morton
2008-07-02 20:51                     ` Andi Kleen
2008-07-02 21:02                       ` Andrew Morton
2008-07-02 21:07                         ` Andi Kleen [this message]
2008-07-02 21:14                           ` Andrew Morton
2008-07-06 17:18                             ` Len Brown
2008-07-06 18:13                               ` Andi Kleen
2008-07-06 18:52                               ` Arjan van de Ven
2008-07-07  6:19                                 ` Andi Kleen
2008-07-07  7:03                                   ` Arjan van de Ven
2008-07-08 15:44                                     ` Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486BEE0D.3030901@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).