From: Andy Grover <andy.grover@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Miller <davem@davemloft.net>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: net tree build failure
Date: Mon, 02 Mar 2009 19:22:55 -0800 [thread overview]
Message-ID: <49ACA28F.5090906@oracle.com> (raw)
In-Reply-To: <20090303125525.1cb0baf9.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Dave,
>
> On Mon, 02 Mar 2009 01:49:58 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Mon, 2 Mar 2009 18:05:14 +1100
>>
>>> Today's linux-next build (powerpc allyesconfig) failed like this:
>>>
>>> net/rds/cong.c: In function 'rds_cong_set_bit':
>>> net/rds/cong.c:284: error: implicit declaration of function 'generic___set_le_bit'
>>> net/rds/cong.c: In function 'rds_cong_clear_bit':
>>> net/rds/cong.c:298: error: implicit declaration of function 'generic___clear_le_bit'
>>> net/rds/cong.c: In function 'rds_cong_test_bit':
>>> net/rds/cong.c:309: error: implicit declaration of function 'generic_test_le_bit'
>> I've fixed this up as follows:
>
> I was actually wondering if this was some API that powerpc had not
> implemented (most other architectures include asm-generic/bitops/le.h in
> their asm/bitops.h via asm-generic/bitops/ext2-non-atomic.h or
> asm-generic/bitops/minix-le.h) or whether RDS should be using some other
> API (since this is the first use of those functions outside the headers
> above).
My 2c,
I think the correct solution is for all archs to define
generic_*_le_bit. In addition ext2_*_bit callers (there are a bunch
besides ext2!) should be fixed.
Some examples:
include/linux/reiserfs_fs.h:#define reiserfs_test_and_set_le_bit
ext2_set_bit
fs/udf/balloc.c:#define udf_clear_bit(nr, addr) ext2_clear_bit(nr, addr)
fs/ext4/ext4.h:#define ext4_set_bit ext2_set_bit
And this one:
lib/find_next_bit.c:static inline unsigned long ext2_swabp(const
unsigned long *
^^^ cargo cult ext2 prefixing???
Regards -- Andy
next prev parent reply other threads:[~2009-03-03 3:23 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 7:05 linux-next: net tree build failure Stephen Rothwell
2009-03-02 9:49 ` David Miller
2009-03-02 16:38 ` Andy Grover
2009-03-03 1:55 ` Stephen Rothwell
2009-03-03 3:22 ` Andy Grover [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-27 2:18 Stephen Rothwell
2010-01-27 4:49 ` David Miller
2010-01-11 7:42 Stephen Rothwell
2010-01-11 8:02 ` David Miller
2010-01-11 8:16 ` Joe Perches
2010-01-11 8:44 ` David Miller
2010-01-11 8:49 ` Stephen Rothwell
2010-01-11 11:16 ` Maciej W. Rozycki
2009-11-18 5:51 Stephen Rothwell
2009-11-18 7:05 ` David Miller
2009-11-19 10:51 ` Shreyas Bhatewara
2009-11-14 6:50 Stephen Rothwell
2009-11-14 13:18 ` Arnaldo Carvalho de Melo
2009-11-09 2:21 Stephen Rothwell
2009-11-09 4:41 ` David Miller
2009-10-13 4:33 Stephen Rothwell
2009-10-13 5:14 ` Michael Chan
2009-10-13 6:20 ` David Miller
2009-10-13 6:19 ` David Miller
2009-06-17 6:31 Stephen Rothwell
2009-06-17 8:36 ` David Miller
2009-06-17 13:10 ` Stephen Rothwell
[not found] <20090521001928.4bf71911.sfr@canb.auug.org.au>
2009-05-20 14:53 ` Eric W. Biederman
2009-05-20 19:44 ` David Miller
2009-04-24 7:01 Stephen Rothwell
2009-04-24 11:53 ` David Miller
2009-04-24 11:57 ` Stephen Rothwell
2009-04-22 0:29 Stephen Rothwell
2009-04-22 0:37 ` Alexander Beregalov
2009-04-22 1:12 ` David Miller
2009-04-20 1:26 Stephen Rothwell
2009-04-20 1:36 ` Alexander Beregalov
2009-04-20 1:43 ` David Miller
2009-04-20 1:50 ` Stephen Rothwell
2009-03-19 4:46 Stephen Rothwell
2009-03-19 5:40 ` David Miller
2009-04-01 19:58 ` Ingo Molnar
2009-04-01 21:22 ` David Miller
2009-03-30 1:15 ` Stephen Rothwell
2009-03-30 1:50 ` Stephen Rothwell
2009-01-26 2:53 Stephen Rothwell
2009-01-26 4:46 ` David Miller
2009-01-26 5:15 ` Stephen Rothwell
2009-01-26 5:17 ` David Miller
2009-01-26 8:31 ` Stephen Rothwell
2009-01-26 19:40 ` David Miller
2009-01-23 7:28 Stephen Rothwell
2009-01-23 7:56 ` David Miller
2009-01-23 8:01 ` Stephen Rothwell
2009-01-23 8:13 ` David Miller
2009-01-23 10:21 ` Stephen Rothwell
2009-01-23 10:39 ` Stephen Rothwell
2009-01-23 10:50 ` Stephen Rothwell
2009-01-24 6:27 ` David Miller
2008-12-09 6:29 Stephen Rothwell
2008-12-09 8:04 ` David Miller
2008-12-09 8:54 ` Stephen Rothwell
2008-12-09 9:05 ` David Miller
2008-12-09 9:12 ` Marcel Holtmann
2008-11-28 3:46 Stephen Rothwell
2008-11-28 7:07 ` David Miller
2008-11-26 7:15 Stephen Rothwell
2008-11-26 7:51 ` Herbert Xu
2008-11-26 8:45 ` David Miller
2008-11-26 9:40 ` Stephen Rothwell
2008-11-24 2:43 Stephen Rothwell
2008-11-24 3:56 ` David Miller
2008-11-24 4:03 ` David Miller
2008-11-24 4:25 ` Stephen Rothwell
2008-11-24 4:28 ` David Miller
2008-11-24 4:49 ` Stephen Rothwell
2008-11-24 5:04 ` David Miller
2008-11-24 5:20 ` Stephen Rothwell
2008-11-24 5:22 ` Stephen Rothwell
2008-11-24 5:23 ` David Miller
2008-11-24 5:29 ` David Miller
2008-11-24 5:45 ` Stephen Rothwell
2008-11-24 5:38 ` Stephen Rothwell
2008-11-24 21:00 ` Sam Ravnborg
2008-11-24 21:52 ` Stephen Hemminger
2008-11-24 22:12 ` Sam Ravnborg
2008-11-25 8:42 ` Stephen Rothwell
2008-11-25 9:01 ` Sam Ravnborg
2008-11-21 2:44 Stephen Rothwell
2008-11-21 4:02 ` Stephen Hemminger
2008-11-21 4:13 ` David Miller
2008-11-20 2:58 Stephen Rothwell
2008-11-20 2:30 Stephen Rothwell
2008-12-29 6:45 ` Stephen Rothwell
2008-09-13 5:03 Stephen Rothwell
2008-09-13 6:24 ` David Miller
2008-09-13 9:42 ` Stephen Rothwell
2008-09-15 0:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ACA28F.5090906@oracle.com \
--to=andy.grover@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).