From: Benny Halevy <bhalevy@panasas.com>
To: "J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
andros@netapp.com,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
linux-nfs@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
pNFS Mailing List <pnfs@linux-nfs.org>
Subject: Re: next-20090406: nfsd build fails
Date: Tue, 07 Apr 2009 21:53:38 +0300 [thread overview]
Message-ID: <49DBA132.5000703@panasas.com> (raw)
In-Reply-To: <20090406171146.GA32436@fieldses.org>
On Apr. 06, 2009, 20:11 +0300, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> On Mon, Apr 06, 2009 at 11:53:28AM +0300, Benny Halevy wrote:
>> On Apr. 06, 2009, 10:27 +0300, Alexander Beregalov <a.beregalov@gmail.com> wrote:
>>> Hi
>>>
>>> fs/nfsd/nfssvc.c: In function 'set_max_drc':
>>> fs/nfsd/nfssvc.c:240: error: 'NFSD_DRC_SIZE_SHIFT' undeclared
>>>
>>> CONFIG_NFSD_V4 is not set
>> Hi Alexander,
>>
>> Thanks for reporting this!
>>
>> Andy, Bruce: please see attached 2 patches fixing compile/link errors
>> with DRC under !defined(CONFIG_NFSD_V4):
>>
>> [PATCH 1/2] SQUASHEM: nfsd41: define NFSD_DRC_SIZE_SHIFT in set_max_drc
>> [PATCH 2/2] SQUASHME: nfsd41: define nfsd4_set_statp as noop for !CONFIG_NFSD_V4
>
> Thanks, applied.
>
> Committing on top (not squashing) since I'd rather not rewrite history
> on a branch I've already sent a pull request for.
Cool. Thanks!
I wasn't aware that you already sent a pull request already...
I got it from mainline now and I'm rebasing and testing
the rest of our stuff on top of it.
>
> (In fact, I'll try to stop rebasing those for-next branches at all this
> time around.)
I'm with you on that.
For 2.6.31, I'd like to send easy-to-swallow patch sets
that we can review and agree upon well ahead of the merge window
(i.e. start, e.g. with the backchannel stuff shortly after 2.6.30-rc1
is cut) and once we're in agreement on it we can put it in linux-next
to be visible to others and get some soak time. This will also
be a good time to freeze it, so it won't be rebased, unless something
important enough requires that. How does that sound?
I think that the same strategy should work for the client side too.
Trond what do you think?
Benny
>
> --b.
next prev parent reply other threads:[~2009-04-07 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 7:27 next-20090406: nfsd build fails Alexander Beregalov
[not found] ` <a4423d670904060027y44550d99g2cb40ce415dbb048-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-06 8:53 ` Benny Halevy
[not found] ` <49D9C308.6020500-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2009-04-06 9:00 ` [PATCH 1/2] SQUASHEM: nfsd41: define NFSD_DRC_SIZE_SHIFT in set_max_drc Benny Halevy
2009-04-06 9:00 ` [PATCH 2/2] SQUASHME: nfsd41: define nfsd4_set_statp as noop for !CONFIG_NFSD_V4 Benny Halevy
2009-04-06 17:11 ` next-20090406: nfsd build fails J. Bruce Fields
2009-04-07 18:53 ` Benny Halevy [this message]
2009-04-07 20:05 ` [pnfs] " William A. (Andy) Adamson
2009-04-09 16:12 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DBA132.5000703@panasas.com \
--to=bhalevy@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=a.beregalov@gmail.com \
--cc=andros@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).