From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] nouveau: fix acpi_lid_open undefined Date: Mon, 24 May 2010 06:53:51 -0700 Message-ID: <4BFA84EF.7070609@oracle.com> References: <20100522170459.4c89723d.sfr@canb.auug.org.au> <20100523170040.3c4aa87c.randy.dunlap@oracle.com> <20100524125628.GA14278@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:30014 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757074Ab0EXNyQ (ORCPT ); Mon, 24 May 2010 09:54:16 -0400 In-Reply-To: <20100524125628.GA14278@srcf.ucam.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Matthew Garrett Cc: Stephen Rothwell , Ben Skeggs , dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org, LKML , David Airlie On 05/24/10 05:56, Matthew Garrett wrote: > On Sun, May 23, 2010 at 05:00:40PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> When CONFIG_ACPI_BUTTON=m (and probably when ACPI_BUTTON is not enabled) >> and NOUVEAU is built-in (not as a loadable module): > > Won't this result in a behavioural difference? The desirable outcome is It could, yes. > that that configuration be impossible, not for that configuration to > build but be buggy. so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***