From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] nouveau: fix acpi_lid_open undefined Date: Mon, 24 May 2010 07:17:21 -0700 Message-ID: <4BFA8A71.4080900@oracle.com> References: <20100522170459.4c89723d.sfr@canb.auug.org.au> <20100523170040.3c4aa87c.randy.dunlap@oracle.com> <20100524125628.GA14278@srcf.ucam.org> <4BFA84EF.7070609@oracle.com> <20100524135940.GA15892@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100524135940.GA15892@srcf.ucam.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Matthew Garrett Cc: Stephen Rothwell , LKML , dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org, Ben Skeggs List-Id: linux-next.vger.kernel.org On 05/24/10 06:59, Matthew Garrett wrote: > On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote: >> On 05/24/10 05:56, Matthew Garrett wrote: >>> Won't this result in a behavioural difference? The desirable outcome is >> >> It could, yes. >> >>> that that configuration be impossible, not for that configuration to >>> build but be buggy. >> >> so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? > > There's an argument that it doesn't need to depend on it, but if button > is a module then nouveau has to be. Except the inverse isn't true. > Kconfig is hard, let's weep gently. Maybe Dave can weep with us when he is back at work... -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***