From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] firmware: fix GOOGLE_SMI kconfig dependency warning Date: Mon, 23 May 2011 08:15:48 -0700 Message-ID: <4DDA7A24.6050909@oracle.com> References: <20110520165507.cba539d5.sfr@canb.auug.org.au> <20110522173802.c0766c64.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:42498 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755415Ab1EWPQW (ORCPT ); Mon, 23 May 2011 11:16:22 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Mike Waychison Cc: linux-next@vger.kernel.org, LKML , Stephen Rothwell , gregkh On 05/22/11 22:39, Mike Waychison wrote: > > On May 22, 2011 5:38 PM, "Randy Dunlap" > wrote: >> >> From: Randy Dunlap > >> >> Is it meaningful/useful to enable EFI_VARS but not EFI? >> That's what GOOGLE_SMI does. Make it enable EFI also. >> >> Fixes this kconfig dependency warning: >> >> warning: (GOOGLE_SMI) selects EFI_VARS which has unmet direct > dependencies (EFI) >> >> Signed-off-by: Randy Dunlap > >> Cc: Mike Waychison > > > Acked. > > Is this a new warning? I haven't seen it before which is weird because > we don't use efi boot. It's not new for 20110520, but I don't know when it began. >> --- >> drivers/firmware/google/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20110520.orig/drivers/firmware/google/Kconfig >> +++ linux-next-20110520/drivers/firmware/google/Kconfig >> @@ -13,6 +13,7 @@ menu "Google Firmware Drivers" >> config GOOGLE_SMI >> tristate "SMI interface for Google platforms" >> depends on ACPI && DMI >> + select EFI >> select EFI_VARS >> help >> Say Y here if you want to enable SMI callbacks for Google > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***