From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES Date: Mon, 23 May 2011 09:21:54 -0700 Message-ID: <4DDA89A2.8010604@oracle.com> References: <20110520165507.cba539d5.sfr@canb.auug.org.au> <20110522173227.5ba18817.randy.dunlap@oracle.com> <4DD9D5EB.3060807@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4DD9D5EB.3060807@st.com> Sender: linux-ide-owner@vger.kernel.org To: viresh kumar Cc: Stephen Rothwell , "linux-ide@vger.kernel.org" , Jeff Garzik , "linux-next@vger.kernel.org" , LKML List-Id: linux-next.vger.kernel.org On 05/22/11 20:35, viresh kumar wrote: > On 05/23/2011 06:02 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix kconfig unmet dependency warning: >> >> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES) >> >> Signed-off-by: Randy Dunlap >> Cc: Viresh Kumar >> --- >> drivers/ata/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20110520.orig/drivers/ata/Kconfig >> +++ linux-next-20110520/drivers/ata/Kconfig >> @@ -313,6 +313,7 @@ config PATA_AMD >> >> config PATA_ARASAN_CF >> tristate "ARASAN CompactFlash PATA Controller Support" >> + depends on DMADEVICES >> select DMA_ENGINE > > Randy, > > I think we can also remove this "select DMA_ENGINE" line. In that case, the newly added "depends on" line is not needed either, since the "select DMA_ENGINE" is what causes the kconfig warning message. > Otherwise, it looks fine. > > Acked-by: Viresh Kumar > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***