From: Mauro Carvalho Chehab <firstname.lastname@example.org> To: Greg KH <email@example.com> Cc: Stephen Rothwell <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, "Igor M. Liplianin" <email@example.com>, Linux Media Mailing List <firstname.lastname@example.org> Subject: Re: linux-next: build failure after merge of the staging.current tree Date: Wed, 08 Jun 2011 13:58:23 -0300 [thread overview] Message-ID: <4DEFAA2F.email@example.com> (raw) In-Reply-To: <20110608161127.GD21645@kroah.com> Hi Greg, Em 08-06-2011 13:11, Greg KH escreveu: > On Wed, Jun 08, 2011 at 11:41:30AM +1000, Stephen Rothwell wrote: >> Hi Greg, >> >> After merging the staging.current tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> drivers/media/video/cx23885/cx23885-cards.c:28:28: fatal error: staging/altera.h: No such file or directory >> >> Caused by commit 85ab9ee946da ("Staging: altera: move .h file to proper >> place"). >> >> I have used the staging.current tree from next-20110607 for today. > > Ok, sorry about that. > > Mauro, Igor, why would another driver need to reference a .h file of a > staging driver? I'll patch it right now to point to the proper place > (down in the staging tree), but it would be good to resolve this > "properly" somehow. > > Next time, please never include a staging driver that isn't > self-contained, and don't create include/staging/ that's not acceptable. The altera driver were discussed for about two kernel cycles. When it was about to be merged upstrem, two people complained about having a FPGA firmware driver inside the Linux Kernel. However, this driver is essential in order to load the firmware for a DVB device. So, to avoid postponing the merge for yet another kernel cycle, I've moved the offending part to staging, and asked for those two people to provide us a new solution up to the next merge window, otherwise, it would be moved it to the proper place. Basically, this driver is used to load the FPGA firmware for the CI module that de-scrambles DVB-C/DVB-T/DVB-S streams, used by some cx23885 devices. Basically, cx23885 gets the firmware file via request_firmware() and uses the altera module to load it. After loaded, the altera-ci driver implements the logic to talk with the CI hardware. There's no Coding Style or any other troubles on this driver that I'm aware, except that the altera driver also allows loading FPGA firmwares via LPT port. The main argue is that there are some userspace tools available to program a FPGA hardware, but the problem is that the cx23885 needs to command the firmware load, as it needs to occur when the device is booted (or resumed). There were some discussions about that at LKML: https://lkml.org/lkml/2011/3/7/270 >From my side, I think that the driver is doing the right approach. Using a different logic will make harder to sync userspace with kernelspace and will require an specialized userspace application for just a few device types (just two of the 30 boards supported by cx23885 currently needs it). Igor, Could you please prepare a patch against linux-next moving it to the proper place? It is probably better to apply such patch at Greg's tree, as he has two patches touching at the altera include files. Also, please get rid of the parallel port support, as you don't need it for cx23885. Thanks, Mauro.
next prev parent reply other threads:[~2011-06-08 16:58 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-08 1:41 Stephen Rothwell 2011-06-08 16:11 ` Greg KH 2011-06-08 16:58 ` Mauro Carvalho Chehab [this message] 2011-06-08 16:21 ` Greg KH 2017-12-14 6:00 Stephen Rothwell 2017-12-14 7:27 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4DEFAA2F.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: linux-next: build failure after merge of the staging.current tree' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).