linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: linux-next: build warning after merge of the moduleh tree
Date: Tue, 2 Aug 2011 09:26:14 +0200	[thread overview]
Message-ID: <4E37A696.2090007@fusionio.com> (raw)
In-Reply-To: <20110801132359.1de051cb8a4a2bdfdad7560c@canb.auug.org.au>

On 2011-08-01 05:23, Stephen Rothwell wrote:
> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> block/bsg-lib.c:75:1: warning: data definition has no type or storage class
> block/bsg-lib.c:75:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> block/bsg-lib.c:75:1: warning: parameter names (without types) in function declaration
> block/bsg-lib.c:164:1: warning: data definition has no type or storage class
> block/bsg-lib.c:164:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> block/bsg-lib.c:164:1: warning: parameter names (without types) in function declaration
> block/bsg-lib.c:210:1: warning: data definition has no type or storage class
> block/bsg-lib.c:210:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> block/bsg-lib.c:210:1: warning: parameter names (without types) in function declaration
> block/bsg-lib.c:244:1: warning: data definition has no type or storage class
> block/bsg-lib.c:244:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> block/bsg-lib.c:244:1: warning: parameter names (without types) in function declaration
> block/bsg-lib.c:297:1: warning: data definition has no type or storage class
> block/bsg-lib.c:297:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> block/bsg-lib.c:297:1: warning: parameter names (without types) in function declaration
> 
> This is an interaction with commit aa387cc89567 ("block: add bsg helper
> library") from the block tree.  That file should have included module.h
> but now would need export.h it seems (just uses EXPORTSYMBOL_GPL).
> 
> I applied the following as a merge fix patch:

Thanks, will you carry this until things are merged? Not easy for me to
fix up.

-- 
Jens Axboe

  reply	other threads:[~2011-08-02  7:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01  3:23 linux-next: build warning after merge of the moduleh tree Stephen Rothwell
2011-08-02  7:26 ` Jens Axboe [this message]
2011-08-02  8:35   ` Stephen Rothwell
2011-08-02  8:42     ` Jens Axboe
2011-08-18  5:09 Stephen Rothwell
2011-08-18  8:26 ` Rafael J. Wysocki
2011-08-18  9:27   ` Stephen Rothwell
2011-08-18 20:57     ` Rafael J. Wysocki
2011-09-28  7:18 Stephen Rothwell
2011-09-28  7:39 ` Pihet-XID, Jean
2011-10-11  9:21 Stephen Rothwell
2011-10-11 13:16 ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E37A696.2090007@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=paul.gortmaker@windriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).