From: Randy Dunlap <rdunlap@xenotime.net>
To: "Kasatkin, Dmitry" <dmitry.kasatkin@intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH -next] digsig: fix build errors
Date: Mon, 21 Nov 2011 07:52:18 -0800 [thread overview]
Message-ID: <4ECA73B2.2010003@xenotime.net> (raw)
In-Reply-To: <CALLzPKYmmah9EcXgN2ruRLoFSjV-ozn1pBMans=n2_ouB8Tqsg@mail.gmail.com>
On 11/21/2011 02:32 AM, Kasatkin, Dmitry wrote:
> On Mon, Nov 21, 2011 at 8:12 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> Fix build errors by adding kconfig dependency on KEYS:
>>
>> lib/digsig.c:106:16: error: dereferencing pointer to incomplete type
>> lib/digsig.c:107:11: error: dereferencing pointer to incomplete type
>> lib/digsig.c:184:14: error: dereferencing pointer to incomplete type
>> lib/digsig.c:223:3: error: 'key_ref_t' undeclared (first use in this function)
>> lib/digsig.c:223:13: error: expected ';' before 'kref'
>> lib/digsig.c:224:3: error: 'kref' undeclared (first use in this function)
>> lib/digsig.c:224:3: error: implicit declaration of function 'keyring_search'
>> lib/digsig.c:231:3: error: implicit declaration of function 'request_key'
>>
>> and after changing lib/Kconfig:
>> warning: (INTEGRITY_DIGSIG) selects DIGSIG which has unmet direct dependencies (CRYPTO && KEYS)
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
>> ---
>> lib/Kconfig | 4 ++--
>> security/integrity/Kconfig | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> --- next-2011-1121.orig/lib/Kconfig
>> +++ next-2011-1121/lib/Kconfig
>> @@ -294,10 +294,10 @@ config MPILIB_EXTRA
>>
>> config DIGSIG
>> tristate "In-kernel signature checker"
>> - depends on CRYPTO
>> + depends on CRYPTO && KEYS
>
> this patch was in /crypto dir before, now it is in /lib...
> I think CRYPTO is not needed at all at the moment..
>
>
>> select MPILIB
>> help
>> Digital signature verification. Currently only RSA is supported.
>> - Implementation is done using GnuPG MPI library
>> + Implementation is done using GnuPG MPI library.
>>
>> endmenu
>> --- next-2011-1121.orig/security/integrity/Kconfig
>> +++ next-2011-1121/security/integrity/Kconfig
>> @@ -5,7 +5,7 @@ config INTEGRITY
>>
>> config INTEGRITY_DIGSIG
>> boolean "Digital signature verification using multiple keyrings"
>> - depends on INTEGRITY
>> + depends on INTEGRITY && CRYPTO && KEYS
>
> Is it really needed, because 2 lines bellow is "select DIGSIG", which
> will depend on KEYS??
Feel free to fix the build errors any way that you want to do it,
but please get them fixed. Don't leave it as is.
>
>> default n
>> select DIGSIG
>> help
>>
>
> Thanks!
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2011-11-21 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 2:39 linux-next: Tree for Nov 21 Stephen Rothwell
2011-11-21 6:12 ` [PATCH -next] digsig: fix build errors Randy Dunlap
2011-11-21 10:32 ` Kasatkin, Dmitry
2011-11-21 15:52 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECA73B2.2010003@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=dmitry.kasatkin@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).