Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: MR Swami Reddy <MR.Swami.Redy@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"Girdwood, Liam" <lrg@ti.com>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"Reddy, MR Swami" <MR.Swami.Reddy@nsc.com>
Subject: Re: linux-next: build warning after merge of the sound-asoc tree
Date: Thu, 05 Apr 2012 20:02:42 +0530
Message-ID: <4F7DAD0A.5040401@ti.com> (raw)
In-Reply-To: <20120405110339.4f83ac849d3bce2893c2ccf8@canb.auug.org.au>

Hi,
I tried to reproduce the below mentioned warning messages using:
 - Latest for-next git repo sources  on x86_64 build machine
 - gcc version 4.3.2
 - -Woverflow option used in KBUILD_CFLAGS

But couldn't see the warning messages.

Below is the quick patch to remove the warning messages (and this patch
will be submitted to alsa-devel mailing list soon).

Signed-off-by: M R Swami Reddy <mr.swami.reddy@ti.com>
---
 sound/soc/codecs/lm49453.c  |   13 +-
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
index 744063d..74409ec 100644
--- a/sound/soc/codecs/lm49453.c
+++ b/sound/soc/codecs/lm49453.c
@@ -1178,27 +1178,24 @@ static int lm49453_set_dai_fmt(struct
snd_soc_dai *codec_dai, unsigned int fmt)
 {
        struct snd_soc_codec *codec = codec_dai->codec;

-       int aif_val = 0;
+       u16 aif_val;
        int mode = 0;
        int clk_phase = 0;
        int clk_shift = 0;

        switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
        case SND_SOC_DAIFMT_CBS_CFS:
-               aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = 0;
                break;
        case SND_SOC_DAIFMT_CBS_CFM:
-               aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
                break;
        case SND_SOC_DAIFMT_CBM_CFS:
-               aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
                break;
        case SND_SOC_DAIFMT_CBM_CFM:
                aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+                         LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
                break;
        default:
                return -EINVAL;




On Thursday 05 April 2012 06:33 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/soc/codecs/lm49453.c: In function 'lm49453_set_dai_fmt':
> sound/soc/codecs/lm49453.c:1189:4: warning: overflow in implicit constant conversion [-Woverflow]
> sound/soc/codecs/lm49453.c:1193:4: warning: overflow in implicit constant conversion [-Woverflow]
> sound/soc/codecs/lm49453.c:1197:4: warning: overflow in implicit constant conversion [-Woverflow]
>
> Introduced by commit dbf7a733f5fb (ASoC: Support TI LM49453 Audio driver"").

  reply index

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05  1:03 Stephen Rothwell
2012-04-05 14:32 ` MR Swami Reddy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-19  3:41 Stephen Rothwell
2021-03-23  5:43 Stephen Rothwell
2021-03-23  6:13 ` Mukunda,Vijendar
2020-11-11  2:34 Stephen Rothwell
2020-10-02  4:14 Stephen Rothwell
2020-09-18  3:21 Stephen Rothwell
2020-09-18  9:21 ` Kai Vehmanen
2020-08-19  1:34 Stephen Rothwell
2020-05-28  3:57 Stephen Rothwell
2020-05-29 13:30 ` Mark Brown
2020-05-29 13:55   ` Pierre-Louis Bossart
2020-05-29 14:27     ` Pierre-Louis Bossart
2020-04-24  6:26 Stephen Rothwell
2020-03-03  1:29 Stephen Rothwell
2020-03-01 23:57 Stephen Rothwell
2019-10-22 23:45 Stephen Rothwell
2019-10-07 23:58 Stephen Rothwell
2019-04-26  3:05 Stephen Rothwell
2019-04-26  3:14 ` Nicolin Chen
2019-04-09  1:46 Stephen Rothwell
2019-03-25 23:01 Stephen Rothwell
2019-04-08 23:12 ` Stephen Rothwell
2019-04-09  4:04   ` Annaliese McDermond
2019-03-19 23:45 Stephen Rothwell
2019-02-21  2:13 Stephen Rothwell
     [not found] <CGME20190213013212epcas5p436da6762dea86287ed3aea31ef2bb830@epcas5p4.samsung.com>
2019-02-13  1:31 ` Stephen Rothwell
2019-02-13 10:35   ` Sylwester Nawrocki
2018-09-07  0:57 Stephen Rothwell
2018-08-02  4:06 Stephen Rothwell
2018-08-02 14:37 ` Mark Brown
2018-07-26  2:19 Stephen Rothwell
2018-07-26  5:58 ` Agrawal, Akshu
2018-05-10  3:09 Stephen Rothwell
2018-02-13  1:51 Stephen Rothwell
2018-02-13  2:55 ` Kuninori Morimoto
2017-11-01  4:13 Stephen Rothwell
2017-09-04  2:27 Stephen Rothwell
2017-08-23  2:20 Stephen Rothwell
2017-08-23  6:03 ` Takashi Iwai
2017-07-03  2:26 Stephen Rothwell
2017-04-27  1:29 Stephen Rothwell
2017-04-27  2:27 ` Vinod Koul
2017-02-01  2:14 Stephen Rothwell
2016-12-06  0:11 Stephen Rothwell
2015-07-13  3:23 Stephen Rothwell
2015-07-13  6:14 ` Valentin Rothberg
2015-03-19  3:45 Stephen Rothwell
2014-04-15  1:44 Stephen Rothwell
2014-02-20  3:01 Stephen Rothwell
2012-06-08  4:03 Stephen Rothwell
2012-01-09  1:55 Stephen Rothwell
2012-01-09  3:03 ` Axel Lin
2012-01-09  3:10   ` Mark Brown
2010-12-27 23:32 Stephen Rothwell
2010-12-28  9:18 ` Peter Ujfalusi
2010-08-17  2:21 Stephen Rothwell
2010-08-17 23:30 ` Liam Girdwood
2010-08-18  8:53   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7DAD0A.5040401@ti.com \
    --to=mr.swami.redy@ti.com \
    --cc=MR.Swami.Reddy@nsc.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-next@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git