From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: linux-next: build failure after merge of the net-next tree Date: Wed, 20 Jun 2012 10:31:26 +0200 Message-ID: <4FE18A5E.204@pengutronix.de> References: <20120620133348.a9ff31a72ffd11818f574fe3@canb.auug.org.au> <20120619.213703.513466167861199217.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD2BF30344E566AB65597BECA" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bhupesh SHARMA Cc: David Miller , "sfr@canb.auug.org.au" , "netdev@vger.kernel.org" , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "federico.vaga@gmail.com" , Giancarlo ASNAGHI , "wg@grandegger.com" List-Id: linux-next.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD2BF30344E566AB65597BECA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/20/2012 06:45 AM, Bhupesh SHARMA wrote: > Hi David, >=20 >> -----Original Message----- >> From: David Miller [mailto:davem@davemloft.net] >> Sent: Wednesday, June 20, 2012 10:07 AM >> To: Bhupesh SHARMA >> Cc: sfr@canb.auug.org.au; netdev@vger.kernel.org; linux- >> next@vger.kernel.org; linux-kernel@vger.kernel.org; >> federico.vaga@gmail.com; Giancarlo ASNAGHI; wg@grandegger.com; >> mkl@pengutronix.de >> Subject: Re: linux-next: build failure after merge of the net-next tre= e >> >> From: Bhupesh SHARMA >> Date: Wed, 20 Jun 2012 12:27:11 +0800 >> >>> clk_get/clk_put* variants are usually used by ARM platforms. >>> Protecting their calls under macro 'CONFIG_HAVE_CLK' should solve the= >> problem. >> >> No, we don't pepper foo.c files with crappy ifdefs. >=20 > So, whether adding a check in Kconfig for HAVE_CLK be a proper solution= ? > But that will limit the compilation of this driver for only platforms w= hich are ARM based. >=20 > One may need to support this driver on x86 like platforms also.. I think the driver is currently used/tested only on ARM only, so what about adding a HAVE_CLK dependency, until Viresh Kumar's patches are available in net-next. Later we can remove it. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enigD2BF30344E566AB65597BECA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/himIACgkQjTAFq1RaXHNu1gCgk22xh8KDyfQfaT7v6HtFg15E WNoAniuhRzJ1KBkQoXiPO60lqwm+YDrT =n41d -----END PGP SIGNATURE----- --------------enigD2BF30344E566AB65597BECA--