linux-next: build failure after merge of the final tree (wireless-next tree related)

linux-next: build failure after merge of the final tree (wireless-next tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function 'brcmf_sdio_dump_console':
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3085:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3085:10: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3113:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]

Caused by commit 4fc0d0160d59 ("brcmfmac: introduce checkdied debugfs
functionality") from the wireless-next tree. Forgot to include vmalloc.h ?

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (wireless-next tree related)

[Arend van Spriel]

On 06/21/2012 07:59 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc 
> allyesconfig) failed like this:
> 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function
> 'brcmf_sdio_dump_console': 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3085:3: error:
> implicit declaration of function 'vzalloc'
> [-Werror=implicit-function-declaration] 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3085:10:
> warning: assignment makes pointer from integer without a cast
> [enabled by default] 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3113:2: error:
> implicit declaration of function 'vfree'
> [-Werror=implicit-function-declaration]
> 
> Caused by commit 4fc0d0160d59 ("brcmfmac: introduce checkdied
> debugfs functionality") from the wireless-next tree. Forgot to
> include vmalloc.h ?

That seems the likely problem.

> I have reverted that commit for today.

I will fix it today.

Gr. AvS

Re: linux-next: build failure after merge of the final tree (wireless-next tree related)

[Arend van Spriel]

On 06/21/2012 07:59 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc 
> allyesconfig) failed like this:
> 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function
> 'brcmf_sdio_dump_console': 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3085:3: error:
> implicit declaration of function 'vzalloc'
> [-Werror=implicit-function-declaration] 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3085:10:
> warning: assignment makes pointer from integer without a cast
> [enabled by default] 
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3113:2: error:
> implicit declaration of function 'vfree'
> [-Werror=implicit-function-declaration]
> 
> Caused by commit 4fc0d0160d59 ("brcmfmac: introduce checkdied
> debugfs functionality") from the wireless-next tree. Forgot to
> include vmalloc.h ?
> 
> I have reverted that commit for today.

Hi Stephen,

We have setup a mailing list brcm80211-dev-list@broadcom.com for
reporting driver issues to make sure the right people are informed
regardless organizational changes. Feel free to use that as needed.

Gr. AvS

Re: linux-next: build failure after merge of the final tree (wireless-next tree related)

[John W. Linville]

On Wed, Mar 19, 2014 at 05:20:35PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function 'iwl_dbgfs_fw_error_dump_release':
> drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(file->private_data);
>   ^
> 
> Caused by commit 1bd3cbc1a0e9 ("iwlwifi: mvm: send udev event upon
> firmware error to dump logs") from the wireless-next tree.  See Rule 1
> from Documentation/SubmitChecklist.
> 
> I have reverted that commit (and commit cdb00563fe2c ("iwlwifi: mvm: BT
> Coex - add debugfs hook to set BT Tx priority") that may depend on it)
> for today.
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

Clearly I need to beg someone for a powerpc box, so that I can find
more of these build failures... :-)

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

RE: linux-next: build failure after merge of the final tree (wireless-next tree related)

[Grumbach, Emmanuel]

> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function
> 'iwl_dbgfs_fw_error_dump_release':
> drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration
> of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(file->private_data);
>   ^

Sorry for that - patch on the way.

> 
> Caused by commit 1bd3cbc1a0e9 ("iwlwifi: mvm: send udev event upon
> firmware error to dump logs") from the wireless-next tree.  See Rule 1
> from Documentation/SubmitChecklist.
> 
> I have reverted that commit (and commit cdb00563fe2c ("iwlwifi: mvm: BT
> Coex - add debugfs hook to set BT Tx priority") that may depend on it)
> for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the final tree (wireless-next tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/net/wireless/iwlwifi/mvm/debugfs.c: In function 'iwl_dbgfs_fw_error_dump_release':
drivers/net/wireless/iwlwifi/mvm/debugfs.c:161:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(file->private_data);
  ^

Caused by commit 1bd3cbc1a0e9 ("iwlwifi: mvm: send udev event upon
firmware error to dump logs") from the wireless-next tree.  See Rule 1
from Documentation/SubmitChecklist.

I have reverted that commit (and commit cdb00563fe2c ("iwlwifi: mvm: BT
Coex - add debugfs hook to set BT Tx priority") that may depend on it)
for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (wireless-next tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/net/wireless/rsi/rsi_mgmt.h:22:0,
                 from drivers/net/wireless/rsi/rsi_91x_core.c:17:
drivers/net/wireless/rsi/rsi_91x_core.c: In function 'rsi_dbg':
drivers/net/wireless/rsi/rsi_main.h:44:20: error: function 'rsi_dbg' can never be inlined because it uses variable argument lists
 static inline void rsi_dbg(u32 zone, const char *fmt, ...)
                    ^

I got quite a few of these.  I am using gcc version 4.8.1 if that matters.

Caused by commit dad0d04fa7ba ("rsi: Add RS9113 wireless driver") from
the wireless-next tree.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (wireless-next tree related)

[Larry Finger]

On 04/04/2013 02:10 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `.rtl92c_phy_ap_calibrate':
> (.text+0x21d14): multiple definition of `.rtl92c_phy_ap_calibrate'
> drivers/net/wireless/rtlwifi/rtl8192c/built-in.o:(.text+0xb1e8): first defined here
> drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `rtl_hal_pwrseqcmdparsing':
> (.opd+0xed0): multiple definition of `rtl_hal_pwrseqcmdparsing'
> drivers/net/wireless/rtlwifi/rtl8723ae/built-in.o:(.opd+0x11a0): first defined here
> drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `rtl92c_phy_ap_calibrate':
> (.opd+0xe58): multiple definition of `rtl92c_phy_ap_calibrate'
> drivers/net/wireless/rtlwifi/rtl8192c/built-in.o:(.opd+0x570): first defined here
> drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `.rtl_hal_pwrseqcmdparsing':
> (.text+0x22164): multiple definition of `.rtl_hal_pwrseqcmdparsing'
> drivers/net/wireless/rtlwifi/rtl8723ae/built-in.o:(.text+0x297a8): first defined here
>
> Caused by commit f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver").
>
> I reverted commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build of new
> driver") for today.

I don't know why it is so hard to remember to do an allyesconfig build, but I 
seem to forget. The 2.5 hours it takes on my box does not help.

As you have probably seen, I just submitted a patch to fix the problem.

Thanks for the report,

Larry

linux-next: build failure after merge of the final tree (wireless-next tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `.rtl92c_phy_ap_calibrate':
(.text+0x21d14): multiple definition of `.rtl92c_phy_ap_calibrate'
drivers/net/wireless/rtlwifi/rtl8192c/built-in.o:(.text+0xb1e8): first defined here
drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `rtl_hal_pwrseqcmdparsing':
(.opd+0xed0): multiple definition of `rtl_hal_pwrseqcmdparsing'
drivers/net/wireless/rtlwifi/rtl8723ae/built-in.o:(.opd+0x11a0): first defined here
drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `rtl92c_phy_ap_calibrate':
(.opd+0xe58): multiple definition of `rtl92c_phy_ap_calibrate'
drivers/net/wireless/rtlwifi/rtl8192c/built-in.o:(.opd+0x570): first defined here
drivers/net/wireless/rtlwifi/rtl8188ee/built-in.o: In function `.rtl_hal_pwrseqcmdparsing':
(.text+0x22164): multiple definition of `.rtl_hal_pwrseqcmdparsing'
drivers/net/wireless/rtlwifi/rtl8723ae/built-in.o:(.text+0x297a8): first defined here

Caused by commit f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver").

I reverted commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build of new
driver") for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]