From: Mark Langsdorf <mark.langsdorf@calxeda.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH -next] ata: fix sata_highbank.c build errors
Date: Fri, 28 Sep 2012 12:56:53 -0500 [thread overview]
Message-ID: <5065E4E5.30004@calxeda.com> (raw)
In-Reply-To: <5065DABA.7060404@xenotime.net>
On 09/28/2012 12:13 PM, Randy Dunlap wrote:
> On 09/19/2012 11:15 AM, Randy Dunlap wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>
>
> ping.
> This build error is still present in linux-next of 20120928.
>
>> Fix build errors in sata_highbank.c by also building libahci.o.
>> Fixes these build errors:
>>
>> drivers/built-in.o: In function `ahci_highbank_hardreset':
>> sata_highbank.c:(.text+0x1edc9a): undefined reference to `ahci_stop_engine'
>> sata_highbank.c:(.text+0x1edfab): undefined reference to `ahci_start_engine'
>> sata_highbank.c:(.text+0x1edfd5): undefined reference to `ahci_dev_classify'
>> drivers/built-in.o: In function `ahci_highbank_resume':
>> sata_highbank.c:(.text+0x1ee0af): undefined reference to `ahci_reset_controller'
>> sata_highbank.c:(.text+0x1ee0e1): undefined reference to `ahci_init_controller'
>> drivers/built-in.o: In function `ahci_highbank_probe':
>> sata_highbank.c:(.init.text+0xc577): undefined reference to `ahci_save_initial_config'
>> sata_highbank.c:(.init.text+0xc5ca): undefined reference to `ahci_set_em_messages'
>> sata_highbank.c:(.init.text+0xc630): undefined reference to `ahci_ignore_sss'
>> sata_highbank.c:(.init.text+0xc660): undefined reference to `ahci_reset_em'
>> sata_highbank.c:(.init.text+0xc72f): undefined reference to `ahci_reset_controller'
>> sata_highbank.c:(.init.text+0xc75a): undefined reference to `ahci_init_controller'
>> sata_highbank.c:(.init.text+0xc774): undefined reference to `ahci_print_info'
>> sata_highbank.c:(.init.text+0xc77c): undefined reference to `ahci_interrupt'
>> drivers/built-in.o:(.data+0x1d5ec): undefined reference to `ahci_ops'
>> drivers/built-in.o:(.data+0x1d690): undefined reference to `ahci_shost_attrs'
>> drivers/built-in.o:(.data+0x1d694): undefined reference to `ahci_sdev_attrs'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>
>> ---
>> drivers/ata/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20120919.orig/drivers/ata/Makefile
>> +++ linux-next-20120919/drivers/ata/Makefile
>> @@ -9,7 +9,7 @@ obj-$(CONFIG_SATA_FSL) += sata_fsl.o
>> obj-$(CONFIG_SATA_INIC162X) += sata_inic162x.o
>> obj-$(CONFIG_SATA_SIL24) += sata_sil24.o
>> obj-$(CONFIG_SATA_DWC) += sata_dwc_460ex.o
>> -obj-$(CONFIG_SATA_HIGHBANK) += sata_highbank.o
>> +obj-$(CONFIG_SATA_HIGHBANK) += sata_highbank.o libahci.o
>>
>> # SFF w/ custom DMA
>> obj-$(CONFIG_PDC_ADMA) += pdc_adma.o
Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
prev parent reply other threads:[~2012-09-28 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 6:26 linux-next: Tree for Sept 19 Stephen Rothwell
2012-09-19 17:58 ` [PATCH -next] staging: fix silicom dependencies and build errors Randy Dunlap
2012-09-19 18:15 ` [PATCH -next] ata: fix sata_highbank.c " Randy Dunlap
2012-09-28 17:13 ` Randy Dunlap
2012-09-28 17:56 ` Mark Langsdorf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065E4E5.30004@calxeda.com \
--to=mark.langsdorf@calxeda.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).