From: "Jan Beulich" <JBeulich@suse.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
gregkh@linuxfoundation.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Jeremy Fitzhardinge <jeremy@goop.org>,
virtualization@lists.linux-foundation.org,
xen-devel <xen-devel@lists.xen.org>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [Xen-devel] linux-next: Tree for Oct 24 (xen)
Date: Thu, 25 Oct 2012 08:30:54 +0100 [thread overview]
Message-ID: <508906CE02000078000A4553@nat28.tlf.novell.com> (raw)
In-Reply-To: <50885EA8.3050007@xenotime.net>
>>> On 24.10.12 at 23:33, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 10/23/2012 09:19 PM, Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 201201023:
>>
>
> on x86_64:
>
> drivers/built-in.o: In function `dbgp_reset_prep':
> (.text+0xb96b5): undefined reference to `xen_dbgp_reset_prep'
> drivers/built-in.o: In function `dbgp_external_startup':
> (.text+0xb9d95): undefined reference to `xen_dbgp_external_startup'
>
>
> Full randconfig file is attached.
So this is because with !USB_SUPPORT but EARLY_PRINTK_DBGP
dbgp_reset_prep() and dbgp_external_startup() get pointlessly
defined and exported. This got broken by the merge
recommendation for the ARM side changes (originally compilation
of drivers/xen/dbgp.c depended on just CONFIG_XEN_DOM0).
>From my pov, fixing the USB side would be the clean solution (i.e.
putting those function definitions inside a CONFIG_USB_SUPPORT
conditional).
The alternative of a smaller change would be to extend the
conditional around the respective xen_dbgp_...() declarations
in include/linux/usb/ehci_def.h to become
#if defined(CONFIG_XEN_DOM0) && defined(CONFIG_USB_SUPPORT)
Please advise towards your preference.
Jan
next prev parent reply other threads:[~2012-10-25 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 4:19 linux-next: Tree for Oct 24 Stephen Rothwell
2012-10-24 21:33 ` linux-next: Tree for Oct 24 (xen) Randy Dunlap
2012-10-25 7:30 ` Jan Beulich [this message]
2012-10-25 10:48 ` [Xen-devel] " Stefano Stabellini
2012-10-25 13:46 ` Konrad Rzeszutek Wilk
2012-10-25 14:05 ` Jan Beulich
2012-10-25 14:15 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508906CE02000078000A4553@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=stefano.stabellini@eu.citrix.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).