From: Tang Chen <tangchen@cn.fujitsu.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the akpm tree
Date: Wed, 23 Jan 2013 14:43:01 +0800 [thread overview]
Message-ID: <50FF8675.8050308@cn.fujitsu.com> (raw)
In-Reply-To: <20130123173358.64b7d2cd01fde200225d46ec@canb.auug.org.au>
On 01/23/2013 02:33 PM, Stephen Rothwell wrote:
> Hi Andrew,
>
> After merging the akpm tree, today's linux-next build (arm defconfig)
> produced this warning:
>
> mm/page_alloc.c:4477:23: warning: 'sanitize_zone_movable_limit' defined but not used [-Wunused-function]
>
> Introduced by commit "page_alloc: introduce zone_movable_limit[] to keep
> movable limit for nodes" from the akpm tree. It is defined both when
> CONFIG_HAVE_MEMBLOCK_NODE_MAP is defined and not, but only used if it is
> defined.
>
Hi Stephen,
Thank you for reporting this. :)
I was aware of this problem by the kbuild rebot, and I think this
problem has been fixed
by the following patch I sent yesterday, and merged into -mm tree this
morning.
Since I could access the lkml web site today, I cannot get an url for you.
Please tell me if your problem is not solved after applying this patch. :)
Thanks. :)
[PATCH Bug fix 3/4] Bug fix: Remove the unused
sanitize_zone_movable_limit() definition.
When CONFIG_HAVE_MEMBLOCK_NODE_MAP is not defined,
sanitize_zone_movable_limit()
is also not used. So remove it.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
mm/page_alloc.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index cd6f8a6..2bd529e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4459,11 +4459,6 @@ static inline unsigned long __meminit
zone_absent_pages_in_node(int nid,
return zholes_size[zone_type];
}
-
-static void __meminit sanitize_zone_movable_limit(void)
-{
-}
-
#endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */
static void __meminit calculate_node_totalpages(struct pglist_data *pgdat,
-- 1.7.1
next prev parent reply other threads:[~2013-01-23 6:43 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 6:33 linux-next: build warning after merge of the akpm tree Stephen Rothwell
2013-01-23 6:43 ` Tang Chen [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-28 8:46 Stephen Rothwell
2021-02-01 7:14 ` Vijayanand Jitta
2020-12-04 10:00 Stephen Rothwell
2020-12-05 5:19 ` Andrew Morton
2020-12-05 9:37 ` Stephen Rothwell
2020-12-07 12:08 ` Dmitry Vyukov
2020-12-07 12:38 ` Dmitry Vyukov
2020-12-07 12:52 ` Marco Elver
2020-12-09 10:06 ` Dmitry Vyukov
2020-12-08 12:01 ` Stephen Rothwell
2020-12-09 4:44 ` Michael Ellerman
2020-12-09 7:07 ` Stephen Rothwell
2020-12-10 0:19 ` Michael Ellerman
2020-12-10 21:17 ` Stephen Rothwell
2020-12-09 10:33 ` Stephen Rothwell
2020-12-09 18:56 ` Kees Cook
2020-02-28 4:35 Stephen Rothwell
2020-02-28 5:23 ` Arjun Roy
2020-01-06 6:11 Stephen Rothwell
2020-01-06 6:07 Stephen Rothwell
2020-01-07 23:11 ` Andrew Morton
2020-01-08 14:52 ` Steven Price
2018-11-30 5:40 Stephen Rothwell
2018-11-30 14:52 ` Dave Rodgman
2017-08-01 6:02 Stephen Rothwell
2017-08-01 6:15 ` Huang, Ying
2017-08-01 21:15 ` Arnd Bergmann
2017-06-26 6:30 Stephen Rothwell
2017-06-26 23:57 ` Wei Yang
2014-05-19 8:13 Stephen Rothwell
2014-05-19 15:13 ` Davidlohr Bueso
2014-05-19 19:48 ` Andrew Morton
2014-05-19 20:56 ` Davidlohr Bueso
2014-05-19 21:17 ` Andrew Morton
2014-05-19 21:36 ` Stephen Rothwell
2014-05-19 22:38 ` Davidlohr Bueso
2013-04-18 8:03 Stephen Rothwell
2013-04-10 8:33 Stephen Rothwell
2013-04-10 8:18 Stephen Rothwell
2013-02-20 6:34 Stephen Rothwell
2013-02-20 14:37 ` Peter Jones
2012-11-09 3:43 Stephen Rothwell
2012-11-09 10:00 ` Grant Likely
2012-10-25 3:35 Stephen Rothwell
2012-04-27 5:44 Stephen Rothwell
2012-04-27 6:22 ` Cyrill Gorcunov
2012-04-27 6:28 ` Stephen Rothwell
2012-04-27 6:40 ` Cyrill Gorcunov
2011-08-10 2:13 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FF8675.8050308@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).