linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the nfsd tree
Date: Fri, 8 Feb 2013 09:41:05 +0400	[thread overview]
Message-ID: <51148FF1.4040108@parallels.com> (raw)
In-Reply-To: <20130203144123.GA22854@fieldses.org>

03.02.2013 18:41, J. Bruce Fields пишет:
> On Sat, Feb 02, 2013 at 07:57:19AM -0500, J. Bruce Fields wrote:
>> On Sat, Feb 02, 2013 at 01:04:03PM +1100, Stephen Rothwell wrote:
>>> Hi,
>>>
>>> After merging the nfsd tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> fs/nfs/dns_resolve.c: In function 'nfs_dns_resolver_cache_init':
>>> fs/nfs/dns_resolve.c:375:4: error: 'struct cache_detail' has no member named 'cache_upcall'
>>> fs/nfs/dns_resolve.c:375:35: warning: left-hand operand of comma expression has no effect [-Wunused-value]
>>> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
>>> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
>>> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
>>> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
>>> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
>>> fs/nfs/dns_resolve.c:375:35: warning: value computed is not used [-Wunused-value]
>>>
>>> Caused by commit aab982cb5dfb ("SUNRPC: remove cache_detail->cache_upcall
>>> callback").
>>
>> Yes, I knew why we'd introduced cache_upcall, so I'm not sure how I
>> overlooked that.  It must have slipped through testing because I didn't
>> set CONFIG_NFS_USE_KERNEL_DNS.
>>
>> We may just be able to revert that patch....  I can take care of that by
>> tomorrow.
>
> Stanislav, any objections to this?
>

The only objection is that I've sent you the patch set witch fixes all these problems already:

"[PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root". :)

The only reason why I removed cache_upcall at all was that all it's users (except NFS DNS cache - my mistake) just call sunrpc_cache_pipe_upcall and thus these 
wrapper looked redundant to me.
Second patch set leaves cache_upcall only for NFS DNS cache (since this upcall is not just a wrapper around sunrpc_cache_pipe_upcall).
And second patch set implies the first one will be dropped.
I can, actually, send one more (incremental  this time) patch set to fix the problem, if you wish.

But it's up to you, what to commit, Bruce.

-- 
Best regards,
Stanislav Kinsbursky

  reply	other threads:[~2013-02-08  5:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-02  2:04 linux-next: build failure after merge of the nfsd tree Stephen Rothwell
2013-02-02 12:57 ` J. Bruce Fields
2013-02-03 14:41   ` J. Bruce Fields
2013-02-08  5:41     ` Stanislav Kinsbursky [this message]
2013-02-08 21:19       ` J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2020-05-08  0:47 Stephen Rothwell
2020-05-12  0:22 ` J. Bruce Fields
2018-10-05  0:01 Stephen Rothwell
2018-10-04 23:54 Stephen Rothwell
2017-08-25  0:24 Stephen Rothwell
2017-08-30 23:48 ` Stephen Rothwell
2017-08-31 15:55   ` J. Bruce Fields
2015-07-20 23:57 Stephen Rothwell
2015-07-21  5:10 ` Kinglong Mee
2014-08-19 16:38 Stephen Rothwell
2014-05-28  2:07 Stephen Rothwell
2014-05-28 18:57 ` J. Bruce Fields
2014-05-26  1:18 Stephen Rothwell
2014-05-27 21:22 ` J. Bruce Fields
2013-04-29  1:24 Stephen Rothwell
2013-04-29 14:53 ` Chuck Lever
2013-04-29 15:45   ` J. Bruce Fields
2013-04-29 16:05     ` Chuck Lever
2013-04-29 16:21       ` Trond Myklebust
2013-04-29 17:04         ` Chuck Lever
2013-04-29 17:37           ` Simo Sorce
2013-04-29 17:38           ` J. Bruce Fields
2013-04-29 17:47             ` Chuck Lever
2013-04-29 17:57               ` Simo Sorce
2013-04-29 17:59               ` J. Bruce Fields
2013-04-29 18:30                 ` Chuck Lever
2013-04-29 18:57                   ` J. Bruce Fields
2013-04-29 19:14                     ` Chuck Lever
2013-04-29 16:29       ` Simo Sorce
2013-04-29 16:37         ` Chuck Lever
2013-04-29 16:46           ` Simo Sorce
2013-03-01  1:04 Stephen Rothwell
2013-03-01  1:19 ` Myklebust, Trond
2013-03-02  3:42   ` J. Bruce Fields
2011-11-15 23:29 Stephen Rothwell
2011-11-16  0:14 ` J. Bruce Fields
2011-11-16  1:26   ` J. Bruce Fields
2010-09-23  1:34 Stephen Rothwell
2010-09-23  2:33 ` J. Bruce Fields
2010-09-23  2:51   ` Neil Brown
2010-09-23  4:03     ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51148FF1.4040108@parallels.com \
    --to=skinsbursky@parallels.com \
    --cc=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).