From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [RFC -next] linux/linkage.h: fix symbol prefix handling Date: Fri, 8 Mar 2013 09:15:37 +0000 Message-ID: <5139AC39.90805@imgtec.com> References: <1362656642-2693-1-git-send-email-james.hogan@imgtec.com> <87sj46wyf2.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from multi.imgtec.com ([194.200.65.239]:17848 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932815Ab3CHJPo (ORCPT ); Fri, 8 Mar 2013 04:15:44 -0500 In-Reply-To: <87sj46wyf2.fsf@rustcorp.com.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Rusty Russell Cc: Al Viro , Michal Marek , Andrew Morton , Guenter Roeck , Jean Delvare , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Frysinger , uclinux-dist-devel@blackfin.uclinux.org, linux-next@vger.kernel.org Hi Rusty, On 08/03/13 00:03, Rusty Russell wrote: > James Hogan writes: >> Also the definition of SYMBOL_PREFIX in is removed as >> it conflicts, isn't used anywhere, and is defined as a string so differs >> from the assembly definition. > > So now, if CONFIG_SYMBOL_PREFIX, SYMBOL_PREFIX is defined on the cmdline > as a string. Otherwise it's empty (not the empty string?): No, SYMBOL_PREFIX is now defined as a non-string, same as asm files, but the now unused definition in linux/kernel.h did define it as a string as it used CONFIG_SYMBOL_PREFIX which is a string. When I said "and is defined as a string" I was referring to the one in linux/kernel.h that this removes. Does that make sense? It's all a bit messy unfortunately (hence RFC). Cheers James