From: Randy Dunlap <rdunlap@infradead.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Benjamin Poirier <bpoirier@suse.de>
Subject: Re: [PATCH 1/1] kconfig: fix lists definition for C++
Date: Mon, 29 Apr 2013 12:28:07 -0700 [thread overview]
Message-ID: <517EC9C7.9000903@infradead.org> (raw)
In-Reply-To: <21ca352b71ca252e1933b1538fe89da8a04395c3.1367258255.git.yann.morin.1998@free.fr>
On 04/29/13 10:59, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The C++ compiler is more strict in that it refuses to assign
> a void* to a struct list_head*.
>
> Fix that by explicitly casting the poisonning constants.
>
> (Tested with all 5 frontends, now.)
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Benjamin Poirier <bpoirier@suse.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> scripts/kconfig/list.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/list.h b/scripts/kconfig/list.h
> index ea1d581..685d80e 100644
> --- a/scripts/kconfig/list.h
> +++ b/scripts/kconfig/list.h
> @@ -125,7 +125,7 @@ static inline void __list_del(struct list_head *prev, struct list_head *next)
> static inline void list_del(struct list_head *entry)
> {
> __list_del(entry->prev, entry->next);
> - entry->next = LIST_POISON1;
> - entry->prev = LIST_POISON2;
> + entry->next = (struct list_head*)LIST_POISON1;
> + entry->prev = (struct list_head*)LIST_POISON2;
> }
> #endif
>
--
~Randy
next prev parent reply other threads:[~2013-04-29 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 17:59 [pull request] Pull request for branch yem-kconfig-for-next Yann E. MORIN
2013-04-29 17:59 ` [PATCH 1/1] kconfig: fix lists definition for C++ Yann E. MORIN
2013-04-29 19:28 ` Randy Dunlap [this message]
2013-04-29 21:54 ` Rob Landley
2013-04-29 22:30 ` Yann E. MORIN
2013-04-29 22:57 ` Rob Landley
2013-05-02 8:48 ` [pull request] Pull request for branch yem-kconfig-for-next Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517EC9C7.9000903@infradead.org \
--to=rdunlap@infradead.org \
--cc=bpoirier@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).