From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] misc: fix various misc/mic/host/ build errors Date: Wed, 16 Oct 2013 12:41:08 -0700 Message-ID: <525EEBD4.7070800@infradead.org> References: <1381762088-18880-1-git-send-email-treding@nvidia.com> <525C481E.1010908@infradead.org> <20131016192648.GA19637@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from merlin.infradead.org ([205.233.59.134]:35578 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756222Ab3JPTlO (ORCPT ); Wed, 16 Oct 2013 15:41:14 -0400 In-Reply-To: <20131016192648.GA19637@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg Kroah-Hartman Cc: Thierry Reding , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Harshavardhan R Kharche , Ashutosh Dixit , Nikhil Rao , Sudeep Dutt On 10/16/13 12:26, Greg Kroah-Hartman wrote: > On Mon, Oct 14, 2013 at 12:38:06PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix various build errors (on x86_64) for drivers/misc/mic/host/: >> >> drivers/misc/mic/host/mic_main.c:378:3: error: too many arguments to function 'sysfs_get_dirent' >> drivers/misc/mic/host/mic_intr.h:134:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default] >> drivers/misc/mic/host/mic_intr.h:134:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] >> drivers/misc/mic/host/mic_intr.h:135:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default] >> drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration] >> drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_read': >> drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration] >> drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_write': >> drivers/misc/mic/host/mic_device.h:183:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration] >> >> Signed-off-by: Randy Dunlap >> Cc: Harshavardhan R Kharche >> Cc: Ashutosh Dixit >> Cc: Greg Kroah-Hartman >> Cc: Nikhil Rao >> Cc: Sudeep Dutt > > This is a -next issue only at this point in time, I thought it was in > the -next tree as a "fixup" already? Are you asking the driver maintainers? -- ~Randy