From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for Oct 17 (pinctrl-single.c) Date: Fri, 18 Oct 2013 17:41:54 -0700 Message-ID: <5261D552.6090401@infradead.org> References: <20131018003847.GH2443@sirena.org.uk> <5261792C.7030203@infradead.org> <20131018233951.GU15154@atomide.com> <5261C72D.1090302@infradead.org> <20131018234914.GV15154@atomide.com> <20131019003925.GW15154@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from merlin.infradead.org ([205.233.59.134]:33661 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232Ab3JSAmD (ORCPT ); Fri, 18 Oct 2013 20:42:03 -0400 In-Reply-To: <20131019003925.GW15154@atomide.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Tony Lindgren Cc: Linus Walleij , Mark Brown , Thierry Reding , "pinctl-single.c" , "linux-kernel@vger.kernel.org" , Olof Johansson On 10/18/13 17:39, Tony Lindgren wrote: > * Tony Lindgren [131018 16:49]: >> * Randy Dunlap [131018 16:41]: >>> On 10/18/13 16:39, Tony Lindgren wrote: >>>> >>>> Looks like we need a little bit of arch specific handling >>>> with the generic IRQ. Fix the issue with an ifdef the >>>> same way as other drivers do. >>>> >>>> ARM needs things set to IRQF_VALID, which also then sets >>>> noprobe. Others seem to use just irq_set_noprobe(). >>>> >>>> Otherwise we can get: >>>> >>>> drivers/pinctrl/pinctrl-single.c: In function 'pcs_irqdomain_map': >>>> drivers/pinctrl/pinctrl-single.c:1750:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration] >>> >>> Did you address this error? I don't see a fix for it... >> >> Yes set_irq_flags() is defined for ARM archs in >> arch/arm/include/asm/hw_irq.h which is included from >> include/linux/irq.h as . So the ifdef >> below takes care of that too. >> >>>> +#ifdef CONFIG_ARM >>>> + set_irq_flags(irq, IRQF_VALID); >>>> +#else >>>> + irq_set_noprobe(irq); >>>> +#endif > > OK I've sent the pull request and Olof has now pulled the fix > into arm-soc next/dt branch. Thanks. Acked-by: Randy Dunlap -- ~Randy