From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Jim Davis <jim.epost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -next] staging/iio/adc: MXS_LRADC depends on INPUT
Date: Wed, 23 Oct 2013 16:55:56 +0100 [thread overview]
Message-ID: <5267F18C.2020107@kernel.org> (raw)
In-Reply-To: <201310220651.03499.marex-ynQEQJNshbs@public.gmane.org>
On 10/22/13 05:51, Marek Vasut wrote:
> Dear Randy Dunlap,
>
>> From: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
>>
>> mxs-lradc.c uses many input_() functions so it should
>> depend on INPUT to fix build errors.
>>
>> drivers/built-in.o: In function `mxs_lradc_ts_unregister':
>> drivers/staging/iio/adc/mxs-lradc.c:905: undefined reference to
>> `input_unregister_device' drivers/staging/iio/adc/mxs-lradc.c:905:
>> undefined reference to `input_unregister_device' drivers/built-in.o: In
>> function `input_report_abs':
>> include/linux/input.h:399: undefined reference to `input_event'
>> include/linux/input.h:399: undefined reference to `input_event'
>> include/linux/input.h:399: undefined reference to `input_event'
>> drivers/built-in.o: In function `input_report_key':
>> include/linux/input.h:389: undefined reference to `input_event'
>> drivers/built-in.o: In function `input_sync':
>> include/linux/input.h:414: undefined reference to `input_event'
>> drivers/built-in.o:include/linux/input.h:389: more undefined references to
>> `input_event' follow
>>
>> Signed-off-by: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
>
> Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> Thanks!
>
> Best regards,
> Marek Vasut
>
prev parent reply other threads:[~2013-10-23 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 19:07 randconfig build error with next-20131021, in drivers/staging/iio/adc Jim Davis
[not found] ` <CA+r1Zhjo08EEoHsWkeDDKoc8Le6eDq4fZxZaa1Jc8cfOLsLsMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-22 4:49 ` [PATCH -next] staging/iio/adc: MXS_LRADC depends on INPUT Randy Dunlap
2013-10-22 4:51 ` Marek Vasut
[not found] ` <201310220651.03499.marex-ynQEQJNshbs@public.gmane.org>
2013-10-23 15:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5267F18C.2020107@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jim.epost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).