From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] PowerCap: Replace dev_attrs with dev_groups Date: Fri, 25 Oct 2013 15:30:19 -0700 Message-ID: <526AF0FB.5060508@infradead.org> References: <1382739255-25134-1-git-send-email-srinivas.pandruvada@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from merlin.infradead.org ([205.233.59.134]:43725 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837Ab3JYWaW (ORCPT ); Fri, 25 Oct 2013 18:30:22 -0400 In-Reply-To: <1382739255-25134-1-git-send-email-srinivas.pandruvada@linux.intel.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Srinivas Pandruvada , linux-next@vger.kernel.org Cc: broonie@kernel.org, rafael.j.wysocki@intel.com, jacob.jun.pan@linux.intel.com, thierry.reding@gmail.com On 10/25/13 15:14, Srinivas Pandruvada wrote: > struct class no longer contains dev_attrs field. Replace dev_attrs > with dev_groups field. > This caused compile error on latest linux-next tree. > > Signed-off-by: Srinivas Pandruvada Acked-by: Randy Dunlap Thanks. > --- > drivers/powercap/powercap_sys.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c > index c22fa4c..af07211 100644 > --- a/drivers/powercap/powercap_sys.c > +++ b/drivers/powercap/powercap_sys.c > @@ -471,17 +471,18 @@ static ssize_t enabled_store(struct device *dev, > > return -ENOSYS; > } > +static DEVICE_ATTR_RW(enabled); > > -static struct device_attribute powercap_def_attrs[] = { > - __ATTR(enabled, S_IWUSR | S_IRUGO, enabled_show, > - enabled_store), > - __ATTR_NULL > +static struct attribute *powercap_dev_attrs[] = { > + &dev_attr_enabled.attr, > + NULL > }; > +ATTRIBUTE_GROUPS(powercap_dev); > > static struct class powercap_class = { > .name = "powercap", > .dev_release = powercap_release, > - .dev_attrs = powercap_def_attrs, > + .dev_groups = powercap_dev_groups, > }; > > struct powercap_zone *powercap_register_zone( > -- ~Randy