From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>, Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH -next] random: needs linux/device.h for struct device
Date: Mon, 04 Nov 2013 08:06:16 -0800 [thread overview]
Message-ID: <5277C5F8.3080609@infradead.org> (raw)
In-Reply-To: <20131104175916.763e3c0cf001b9f948f2baa7@canb.auug.org.au>
on x86_64:
drivers/char/random.c: In function 'add_device_attach_randomness':
drivers/char/random.c:837:41: error: dereferencing pointer to incomplete type
need to #include <linux/device.h> for struct device, I think.
Yes, that works.
---
From: Randy Dunlap <rdunlap@infradead.org>
Fix struct device build failure on x86_64 by including <linux/device.h>:
drivers/char/random.c: In function 'add_device_attach_randomness':
drivers/char/random.c:837:41: error: dereferencing pointer to incomplete type
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/char/random.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20131104.orig/drivers/char/random.c
+++ linux-next-20131104/drivers/char/random.c
@@ -240,6 +240,7 @@
#include <linux/kernel.h>
#include <linux/major.h>
#include <linux/string.h>
+#include <linux/device.h>
#include <linux/fcntl.h>
#include <linux/slab.h>
#include <linux/random.h>
---
next prev parent reply other threads:[~2013-11-04 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 6:59 linux-next: Tree for Nov 4 Stephen Rothwell
2013-11-04 16:06 ` Randy Dunlap [this message]
2013-11-04 16:32 ` [PATCH -next] random: needs linux/device.h for struct device Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5277C5F8.3080609@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).