From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jim Davis <jim.epost@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org
Subject: Re: randconfig build error with next-20140108, in drivers/xen/platform-pci.c
Date: Fri, 10 Jan 2014 15:33:45 +0000 [thread overview]
Message-ID: <52D012D9.1010602@citrix.com> (raw)
In-Reply-To: <20140110150738.GC19124@phenom.dumpdata.com>
On 10/01/14 15:07, Konrad Rzeszutek Wilk wrote:
> On Wed, Jan 08, 2014 at 03:32:00PM -0700, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> drivers/xen/platform-pci.c: In function ‘platform_pci_init’:
>> drivers/xen/platform-pci.c:131:2: error: implicit declaration of
>> function ‘pci_request_region’ [-Werror=implicit-function-declaration]
>> ret = pci_request_region(pdev, 1, DRV_NAME);
>> ^
>> drivers/xen/platform-pci.c:170:2: error: implicit declaration of
>> function ‘pci_release_region’ [-Werror=implicit-function-declaration]
>> pci_release_region(pdev, 0);
>> ^
>> cc1: some warnings being treated as errors
>> make[2]: *** [drivers/xen/platform-pci.o] Error 1
>>
>> These warnings appeared too:
>>
>> warning: (XEN_PVH) selects XEN_PVHVM which has unmet direct
>> dependencies (HYPERVISOR_GUEST && XEN && PCI && X86_LOCAL_APIC)
>
> Hey Jim,
>
> This fix works for me:
>
>
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> index d88bfd6..01b9026 100644
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -53,6 +53,5 @@ config XEN_DEBUG_FS
>
> config XEN_PVH
> bool "Support for running as a PVH guest"
> - depends on X86_64 && XEN
> - select XEN_PVHVM
> + depends on X86_64 && XEN && XEN_PVHVM
> def_bool n
>
> David, you OK with that? You suggested to use 'select' in the patchset
> instead of 'depends' and this throws away your suggestion.
Yes.
David
prev parent reply other threads:[~2014-01-10 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 22:32 randconfig build error with next-20140108, in drivers/xen/platform-pci.c Jim Davis
2014-01-10 15:07 ` Konrad Rzeszutek Wilk
2014-01-10 15:33 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D012D9.1010602@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jim.epost@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).