From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: linux-next: manual merge of the akpm-current tree with the tip tree Date: Tue, 14 Jan 2014 08:19:08 -0800 Message-ID: <52D5637C.9000609@zytor.com> References: <20140114155331.88d170d3c991b9465c23a537@canb.auug.org.au> <20140114125153.GY7572@laptop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:52149 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbaANQUF (ORCPT ); Tue, 14 Jan 2014 11:20:05 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven , Peter Zijlstra Cc: Stephen Rothwell , Andrew Morton , Thomas Gleixner , Ingo Molnar , Linux-Next , "linux-kernel@vger.kernel.org" , Davidlohr Bueso On 01/14/2014 05:17 AM, Geert Uytterhoeven wrote: >> >> This seems terribly broken, the *futex_value*() ops should not need >> that; they are supposed to access userspace without any of that. > > Why don't they need set_fs(USER_DS)? > > Gr{oetje,eeting}s, > > Geert Because USER_DS is the normal operating state? It would appear m68k is the only(?) arch that calls initcalls with get_fs() == KERNEL_DS... -hpa