From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST Date: Tue, 09 Sep 2014 17:30:25 +0200 Message-ID: <540F1D11.9030400@samsung.com> References: <20140909124306.2d5a0d76@canb.auug.org.au> <6cbd00c5f2d342b573aaf9c0e533778374dd2e1e.1410273306.git.m.chehab@samsung.com> <540F15B2.3000902@samsung.com> <20140909120936.527bd852.m.chehab@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20140909120936.527bd852.m.chehab@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Sylwester Nawrocki , Linux Media Mailing List , Mauro Carvalho Chehab , Kukjin Kim , Kamil Debski , Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell List-Id: linux-next.vger.kernel.org Hi Mauro, Sylwester, On 09/09/2014 05:09 PM, Mauro Carvalho Chehab wrote: > Em Tue, 09 Sep 2014 16:58:58 +0200 > Sylwester Nawrocki escreveu: > >> On 09/09/14 16:38, Mauro Carvalho Chehab wrote: >>> ERROR: "__bad_ndelay" [drivers/media/platform/s5p-jpeg/s5p-jpeg.ko] undefined! >>> >>> Yet, it sounds a bad idea to use ndelay to wait for 100 us >>> for the device to reset. >>> >>> Reported-by: Stephen Rothwell >>> Signed-off-by: Mauro Carvalho Chehab >>> >>> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c >>> index e51c078360f5..01eeacf28843 100644 >>> --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c >>> +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c >>> @@ -23,7 +23,9 @@ void exynos4_jpeg_sw_reset(void __iomem *base) >>> reg = readl(base + EXYNOS4_JPEG_CNTL_REG); >>> writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + EXYNOS4_JPEG_CNTL_REG); >>> >>> +#ifndef CONFIG_COMPILE_TEST >>> ndelay(100000); >>> +#endif >> >> Wouldn't be a better fix to replace ndelay(100000); with udelay(100), >> rather than sticking in a not so pretty #ifndef ? > > Works for me. I'll submit a new version. > >> I guess usleep_range() couldn't simply be used, since >> exynos4_jpeg_sw_reset() is called with a spinlock held. > > Ok. Within few days I will perform some hardware tests, to verify if there is more room for improvement here. Best Regards, Jacek Anaszewski