From: David Vrabel <david.vrabel@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Xen Devel <Xen-devel@lists.xensource.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Wei Liu <wei.liu2@citrix.com>,
Paul Durrant <paul.durrant@citrix.com>
Subject: Re: linux-next: build failure after merge of the xen-tip tree
Date: Wed, 15 Apr 2015 11:03:30 +0100 [thread overview]
Message-ID: <552E3772.7050209@citrix.com> (raw)
In-Reply-To: <552B802A.3080709@oracle.com>
On 13/04/15 09:36, Bob Liu wrote:
> Hi Stephen,
>
> On 04/13/2015 04:09 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the xen-tip tree, today's linux-next build (x86_64
>> allmodconfig)
>> failed like this:
>>
>> drivers/char/tpm/xen-tpmfront.c: In function 'setup_ring':
>> drivers/char/tpm/xen-tpmfront.c:203:7: warning: passing argument 2 of
>> 'xenbus_grant_ring' makes pointer from integer without a cast
>> rv = xenbus_grant_ring(dev, virt_to_mfn(priv->shr));
>> ^
>> In file included from drivers/char/tpm/xen-tpmfront.c:17:0:
>> include/xen/xenbus.h:206:5: note: expected 'void *' but argument is of
>> type 'long unsigned int'
>> int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
>> ^
>> drivers/char/tpm/xen-tpmfront.c:203:7: error: too few arguments to
>> function 'xenbus_grant_ring'
>> rv = xenbus_grant_ring(dev, virt_to_mfn(priv->shr));
>> ^
>> In file included from drivers/char/tpm/xen-tpmfront.c:17:0:
>> include/xen/xenbus.h:206:5: note: declared here
>> int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
>> ^
>>
>> Caused by commit 1b1586eeeb8c ("xenbus_client: Extend interface to
>> support multi-page ring").
>>
>> I have used the xen-tip tree from next-20150410 for today.
>>
>
> Sorry for this issue, I missed the xentpm-front.c file in that patch.
> (Original patch from Wei Liu already included the right modification
> which didn't exist in Paul's.)
>
> Attached patch should fix this build failure.
Thanks. I've folded this in.
David
next prev parent reply other threads:[~2015-04-15 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 8:09 linux-next: build failure after merge of the xen-tip tree Stephen Rothwell
2015-04-13 8:36 ` Bob Liu
2015-04-15 5:00 ` Stephen Rothwell
2015-04-15 10:03 ` David Vrabel [this message]
2017-08-31 5:22 Stephen Rothwell
2018-07-30 5:12 Stephen Rothwell
2018-07-30 7:40 ` Oleksandr Andrushchenko
2018-08-16 0:09 ` Stephen Rothwell
2021-09-15 1:11 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E3772.7050209@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=bob.liu@oracle.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=sfr@canb.auug.org.au \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).