linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the nand tree
Date: Wed, 11 Mar 2020 20:20:08 +0100	[thread overview]
Message-ID: <5581444.lOV4Wx5bFT@z50> (raw)
In-Reply-To: <20200311111041.2dd477f5@xps13>

Hi Miquel,

On Wednesday, March 11, 2020 11:10:41 A.M. CET Miquel Raynal wrote:
> Hi Stephen,
> 
> + Janusz, ams-delta patch author
> 
> Stephen Rothwell <sfr@canb.auug.org.au> wrote on Wed, 11 Mar 2020
> 13:16:16 +1100:
> 
> > Hi all,
> > 
> > After merging the nand tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> 
> Thanks for the report.
> 
> > 
> > FATAL: modpost: drivers/mtd/nand/raw/ams-delta: sizeof(struct of_device_id)=200 is not a modulo of the size of section __mod_of__<identifier>_device_table=64.
> > Fix definition of struct of_device_id in mod_devicetable.h
> > 
> > Maybe caused by commit
> > 
> >   966d708517e3 ("mtd: rawnand: ams-delta: Add module device tables")
> > 
> > But I have no idea why.
> > 
> 
> This is strange. I think this is caused because of the addition of a
> second device table with the same "of" scope. Changing one of them to
> "platform" (the legacy one) seems to fix the problem.
> 
> Janusz, Is the following change okay for you? I would like to apply it
> today so that linux-next get's updated with the 50+ stack of new
> patches by tomorrow.
> 
> 	--- a/drivers/mtd/nand/raw/ams-delta.c
> 	+++ b/drivers/mtd/nand/raw/ams-delta.c
> 	@@ -411,7 +411,7 @@ static const struct platform_device_id gpio_nand_plat_id_table[] = {
> 	                /* sentinel */
> 	        },
> 	 };
> 	-MODULE_DEVICE_TABLE(of, gpio_nand_plat_id_table);
> 	+MODULE_DEVICE_TABLE(platform, gpio_nand_plat_id_table);

Evidently a copy-paste error on my side, sorry for that.

Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>

Thanks,
Janusz

>  
> 	 static struct platform_driver gpio_nand_driver = {
> 	        .probe          = gpio_nand_probe,
> 
> 
> Thanks,
> Miquèl
> 





  parent reply	other threads:[~2020-03-11 19:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  2:16 linux-next: build failure after merge of the nand tree Stephen Rothwell
2020-03-11 10:10 ` Miquel Raynal
2020-03-11 14:01   ` Boris Brezillon
2020-03-11 19:20   ` Janusz Krzysztofik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-08-21  2:02 Stephen Rothwell
2023-08-21  5:44 ` Md Sadre Alam
2022-09-21  1:32 Stephen Rothwell
2020-12-08  2:14 Stephen Rothwell
2020-09-14  1:45 Stephen Rothwell
2020-09-14  9:50 ` Alex Dewar
2020-09-14 10:58   ` Miquel Raynal
2020-09-08  3:35 Stephen Rothwell
2020-09-10  4:12 ` Stephen Rothwell
2020-09-11 16:58   ` Miquel Raynal
2020-05-25 10:45 Stephen Rothwell
2020-05-25 11:54 ` Miquel Raynal
2020-05-12  4:08 Stephen Rothwell
2020-05-12  7:04 ` Miquel Raynal
2019-04-01 23:14 Stephen Rothwell
2019-04-01 23:31 ` Paul Cercueil
2019-04-02  7:27   ` Miquel Raynal
2019-04-02  9:21     ` Miquel Raynal
2019-04-02 11:56   ` Miquel Raynal
2019-04-02 12:00     ` Paul Cercueil
2019-04-02 12:16       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5581444.lOV4Wx5bFT@z50 \
    --to=jmkrzyszt@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).