From: Randy Dunlap <rdunlap@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Subject: Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c)
Date: Thu, 1 Oct 2015 11:12:12 -0700 [thread overview]
Message-ID: <560D777C.6050009@infradead.org> (raw)
In-Reply-To: <20151001174958.GC3544@pd.tnic>
On 10/01/15 10:49, Borislav Petkov wrote:
> On Thu, Oct 01, 2015 at 10:39:32AM -0700, Randy Dunlap wrote:
>> On 09/30/15 23:50, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20150930:
>>>
>>
>>
>> on x86_64:
>>
>> ../arch/x86/ras/mce_amd_inj.c: In function 'toggle_nb_mca_mst_cpu':
>> ../arch/x86/ras/mce_amd_inj.c:214:42: warning: dereferencing 'void *' pointer [enabled by default]
>> struct pci_dev *F3 = node_to_amd_nb(nid)->misc;
>> ^
>> ../arch/x86/ras/mce_amd_inj.c:214:42: error: request for member 'misc' in something not a structure or union
>
> Thanks Randy,
>
> this is most likely due to us using node_to_amd_nb() - an AMD_NB
> facility - but we're not depending on it. Does that help?
Yes, thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> diff --git a/arch/x86/ras/Kconfig b/arch/x86/ras/Kconfig
> index 10fea5fc821e..98b3ef750984 100644
> --- a/arch/x86/ras/Kconfig
> +++ b/arch/x86/ras/Kconfig
> @@ -1,6 +1,6 @@
> config AMD_MCE_INJ
> tristate "Simple MCE injection interface for AMD processors"
> - depends on RAS && EDAC_DECODE_MCE && DEBUG_FS
> + depends on RAS && EDAC_DECODE_MCE && DEBUG_FS && AMD_NB
> default n
> help
> This is a simple debugfs interface to inject MCEs and test different
>
--
~Randy
prev parent reply other threads:[~2015-10-01 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 6:50 linux-next: Tree for Oct 1 Stephen Rothwell
2015-10-01 17:26 ` linux-next: Tree for Oct 1 (ipvs) Randy Dunlap
2015-10-02 0:45 ` Simon Horman
2015-10-01 17:39 ` linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c) Randy Dunlap
2015-10-01 17:49 ` Borislav Petkov
2015-10-01 18:12 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D777C.6050009@infradead.org \
--to=rdunlap@infradead.org \
--cc=aravind.gopalakrishnan@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).