Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Rich Felker <dalias@libc.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mark Brown <broonie@linaro.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>
Subject: Re: linux-next: build warning after merge of the tip tree
Date: Mon, 25 Jul 2016 15:11:48 +0200
Message-ID: <57961014.7030902@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1607250915160.5629@nanos>

On 07/25/2016 09:16 AM, Thomas Gleixner wrote:
> On Sun, 24 Jul 2016, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
>> produced this warning:
>>
>> In file included from include/linux/clocksource.h:18:0,
>>                  from include/linux/clockchips.h:13,
>>                  from drivers/clocksource/jcore-pit.c:14:
>> include/linux/of.h:1004:20: warning: comparison of distinct pointer types lacks a cast
>>         .data = (fn == (fn_type)NULL) ? fn : fn  }
>>                     ^
>> include/linux/of.h:1020:3: note: in expansion of macro '_OF_DECLARE'
>>    _OF_DECLARE(table, name, compat, fn, of_init_fn_1_ret)
>>    ^
>> include/linux/clocksource.h:247:2: note: in expansion of macro 'OF_DECLARE_1_RET'
>>   OF_DECLARE_1_RET(clksrc, name, compat, fn)
>>   ^
>> drivers/clocksource/jcore-pit.c:277:1: note: in expansion of macro 'CLOCKSOURCE_OF_DECLARE'
>>  CLOCKSOURCE_OF_DECLARE(jcore_pit, "jcore,pit", jcore_pit_init);
>>  ^
>>
>> Introduced by commits
>>
>>   b7c4db861683 ("clocksource/drivers/clksrc-probe: Introduce init functions with return code")
>>   177cf6e52b0a ("clocksources: Switch back to the clksrc table")
>>
>> interacting with commit
>>
>>   e0aa0655c60b ("clocksource: add J-Core timer/clocksource driver")
>>
>> from the sh tree.
> 
> And why is that driver coming through the superh tree and not through the
> clocksource maintainers? It's not only based on an old interface it's probably
> unreviewed as well ...

Rich,

why are these changes in linux-next ?

Except I am missing something, I don't see a new version sent for review
on the mailing list. The interrupt controller driver is almost empty as
stated by Marc Zyngier and there is no explanation / discussion about it.

I don't know the goal of adding those patches in linux-next via your
tree, may be you misunderstood how linux-next works and you should
remove them. But if the purpose was to merge the patches, I remind you
that being an arch maintainer does not give you the right to apply any
patches, everywhere, at all cost, without review, because you want them
in, you must follow the process, otherwise you take the risk to upset a
lot of people and to be kicked out.

 -- Daniel




-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply index

Thread overview: 137+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24  5:32 Stephen Rothwell
2016-07-25  7:16 ` Thomas Gleixner
2016-07-25 13:11   ` Daniel Lezcano [this message]
2016-07-25 14:53     ` Rich Felker
2016-07-25 16:42       ` Mark Brown
2016-07-25 17:54         ` Rich Felker
2016-07-25 14:48   ` Rich Felker
  -- strict thread matches above, loose matches on Subject: below --
2020-11-05  7:06 Stephen Rothwell
2020-11-06  4:35 ` Stephen Rothwell
2020-10-28  3:23 Stephen Rothwell
2020-11-15 22:17 ` Stephen Rothwell
2020-11-15 22:23 ` Balbir Singh
2020-11-17  5:21   ` Balbir Singh
2020-11-23  7:23     ` Stephen Rothwell
2020-10-08  4:28 Stephen Rothwell
2020-10-08  9:02 ` Borislav Petkov
2020-09-25  9:36 Stephen Rothwell
2020-09-14  3:22 Stephen Rothwell
2020-09-14 20:11 ` Kees Cook
2020-09-14 22:35   ` Stephen Rothwell
2020-10-01 11:02     ` Stephen Rothwell
2020-10-02 22:46       ` Kees Cook
2020-10-03 21:54 ` Kees Cook
2020-10-03 23:24   ` Stephen Rothwell
2020-10-04  7:42     ` Kees Cook
2020-10-04  8:27     ` Kees Cook
2020-10-04 10:00       ` Stephen Rothwell
2020-10-05  2:44         ` Kees Cook
2020-10-14 22:25           ` Stephen Rothwell
2020-10-14 23:10             ` Kees Cook
2020-10-15  0:19               ` Stephen Rothwell
2020-05-21 11:56 Stephen Rothwell
2020-05-19  6:57 Stephen Rothwell
2020-05-19  7:12 ` Steve French
2020-04-28  6:29 Stephen Rothwell
2020-03-30  2:47 Stephen Rothwell
2020-03-31 21:57 ` Stephen Rothwell
2020-04-01 10:25   ` Thomas Gleixner
2020-04-01 22:00     ` Stephen Rothwell
2020-04-01 22:39       ` Thomas Gleixner
2020-04-13  0:01         ` Stephen Rothwell
2020-04-14  8:42           ` Thomas Gleixner
2020-01-20  5:38 Stephen Rothwell
2020-01-20  6:00 ` Viresh Kumar
2020-01-07  5:43 Stephen Rothwell
2020-01-07  7:16 ` Ingo Molnar
2020-01-07  7:22   ` Shile Zhang
2019-07-26  3:05 Stephen Rothwell
2019-07-26  4:49 ` Josh Poimboeuf
2019-07-26  5:49   ` Stephen Rothwell
2018-11-06  0:46 Stephen Rothwell
2018-12-19  0:55 ` Stephen Rothwell
2018-09-11  3:53 Stephen Rothwell
2018-09-12 19:35 ` Thomas Gleixner
2018-03-23  2:28 Stephen Rothwell
2018-03-23  8:31 ` Christoph Hellwig
2018-03-23  9:57   ` Stephen Rothwell
2018-03-16  5:37 Stephen Rothwell
2018-03-16  5:52 ` Dou Liyang
2018-03-16  6:04   ` Dou Liyang
2018-03-16  7:55 ` Thomas Gleixner
2018-01-10  4:41 Stephen Rothwell
2017-09-27  3:42 Stephen Rothwell
2017-09-27 11:50 ` Prarit Bhargava
2017-06-28  7:15 Stephen Rothwell
2017-06-23  3:58 Stephen Rothwell
2017-06-23  4:00 ` Stephen Rothwell
2017-06-23  4:10   ` Michael Ellerman
2017-06-23  4:22     ` Stephen Rothwell
2016-12-14  2:28 Stephen Rothwell
2016-12-14  7:24 ` Ingo Molnar
2016-12-14  8:05   ` Richard Weinberger
2016-12-14  8:26     ` Stephen Rothwell
2016-12-14  8:10   ` Stephen Rothwell
2016-04-07  5:26 Stephen Rothwell
2016-04-07  8:48 ` Ingo Molnar
2016-04-07 12:03   ` Stephen Rothwell
2015-05-12  3:35 Stephen Rothwell
2014-08-05  0:58 Stephen Rothwell
2014-07-18  5:00 Stephen Rothwell
2014-07-18 19:16 ` H. Peter Anvin
2014-07-18 19:57   ` Andy Lutomirski
2014-07-18 20:05     ` H. Peter Anvin
2014-07-18 20:08       ` Andy Lutomirski
2014-07-18 20:15         ` H. Peter Anvin
2014-07-18 20:20           ` Andy Lutomirski
2014-07-18 20:50             ` H. Peter Anvin
2014-06-16  1:57 Stephen Rothwell
2014-06-20  4:24 ` Stephen Rothwell
2014-06-20  4:30   ` H. Peter Anvin
2014-06-20  4:35     ` Stephen Rothwell
2014-03-06  6:12 Stephen Rothwell
2014-02-24  4:17 Stephen Rothwell
2014-02-24  5:56 ` Stephen Rothwell
2014-02-24  6:12   ` Andrew Morton
2014-02-24  6:23     ` Stephen Rothwell
2014-02-24 15:48 ` Andi Kleen
2014-02-24 15:51   ` H. Peter Anvin
2014-03-06  4:00 ` Stephen Rothwell
2014-03-28  5:52   ` Stephen Rothwell
2014-03-31  9:45     ` Thomas Gleixner
2014-03-31 10:57       ` Stephen Rothwell
2014-04-01  0:26         ` Stephen Rothwell
2014-04-01  1:56           ` H. Peter Anvin
2013-08-19  4:26 Stephen Rothwell
2013-08-19  6:58 ` Ingo Molnar
2013-08-20  0:52   ` Andi Kleen
2013-08-20  6:42     ` Ingo Molnar
2013-08-30  8:55       ` Stephen Rothwell
2013-08-30 20:42         ` Andi Kleen
2013-08-31  6:41           ` Ingo Molnar
2013-02-02  5:58 Stephen Rothwell
2013-02-02  5:55 Stephen Rothwell
2013-02-02  5:51 Stephen Rothwell
2013-01-30 11:41 Stephen Rothwell
2012-10-01 14:54 Stephen Rothwell
2012-10-01 16:10 ` Josh Triplett
2012-09-27  7:46 Stephen Rothwell
2011-09-14  6:34 Stephen Rothwell
2011-09-14  7:49 ` Yong Zhang
2011-09-14  9:37 ` Thomas Gleixner
2011-09-14  9:43   ` Shan Hai
2011-09-14  6:22 Stephen Rothwell
2010-11-29  1:11 Stephen Rothwell
2010-09-03  2:10 Stephen Rothwell
2010-09-03  2:12 ` Stephen Rothwell
2010-09-03  9:04   ` Wu Fengguang
2010-09-03 10:07     ` Haicheng Li
2010-05-17  5:58 Stephen Rothwell
2010-03-17  3:57 Stephen Rothwell
2010-03-17  4:00 ` KOSAKI Motohiro
2010-03-17  4:52   ` Stephen Rothwell
2010-03-17  7:02 ` Ingo Molnar
2010-03-17  8:02   ` KOSAKI Motohiro
2010-02-23  5:01 Stephen Rothwell
2010-02-23  8:52 ` Yinghai Lu
2010-02-23 10:43   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57961014.7030902@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=Marc.Zyngier@arm.com \
    --cc=broonie@linaro.org \
    --cc=dalias@libc.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git