From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Kamil Debski <k.debski@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-next@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST
Date: Tue, 09 Sep 2014 19:54:19 +0200 [thread overview]
Message-ID: <60097822.tu6OncvLxQ@wuerfel> (raw)
In-Reply-To: <20140909120936.527bd852.m.chehab@samsung.com>
On Tuesday 09 September 2014 12:09:36 Mauro Carvalho Chehab wrote:
> -exynos4.c
> > > index e51c078360f5..01eeacf28843 100644
> > > --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> > > +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> > > @@ -23,7 +23,9 @@ void exynos4_jpeg_sw_reset(void __iomem *base)
> > > reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
> > > writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + EXYNOS4_JPEG_CNTL_REG);
> > >
> > > +#ifndef CONFIG_COMPILE_TEST
> > > ndelay(100000);
> > > +#endif
> >
> > Wouldn't be a better fix to replace ndelay(100000); with udelay(100),
> > rather than sticking in a not so pretty #ifndef ?
>
> Works for me. I'll submit a new version.
New version looks good to me. On a more general level, I would argue
that we should not disable code based on COMPILE_TEST. The typical
use of this symbol is to make it possible to compile more code, not
to change the behavior of code on machines that were able to build
it already.
Arnd
next prev parent reply other threads:[~2014-09-09 17:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 2:43 linux-next: build failure after merge of the v4l-dvb tree Stephen Rothwell
2014-09-09 3:05 ` Mauro Carvalho Chehab
2014-09-09 14:38 ` [PATCH 1/3] omap-dma: Allow compile-testing omap1_camera driver Mauro Carvalho Chehab
2014-09-09 14:38 ` [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST Mauro Carvalho Chehab
2014-09-09 14:58 ` Sylwester Nawrocki
2014-09-09 15:09 ` Mauro Carvalho Chehab
2014-09-09 15:30 ` Jacek Anaszewski
2014-09-09 16:10 ` [PATCHv2 " Mauro Carvalho Chehab
2014-09-09 17:10 ` Sylwester Nawrocki
2014-09-09 17:19 ` Fabio Estevam
2014-09-09 17:54 ` Arnd Bergmann [this message]
2014-09-09 18:40 ` [PATCH " Mauro Carvalho Chehab
[not found] ` <6cbd00c5f2d342b573aaf9c0e533778374dd2e1e.1410273306.git.m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-09 14:38 ` [PATCH 3/3] [media] vpif: Fix compilation with allmodconfig Mauro Carvalho Chehab
2014-09-09 18:30 ` Prabhakar Lad
2014-09-09 14:40 ` [PATCH 1/3] omap-dma: Allow compile-testing omap1_camera driver Nishanth Menon
2014-09-09 14:58 ` Tony Lindgren
2014-09-09 14:41 ` Russell King - ARM Linux
2014-09-09 15:36 ` Mauro Carvalho Chehab
2014-09-09 17:52 ` Mauro Carvalho Chehab
2014-09-10 16:25 ` Tony Lindgren
2014-09-11 10:45 ` Russell King - ARM Linux
2014-09-09 18:54 ` [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST Mauro Carvalho Chehab
2014-09-09 18:54 ` [PATCHv3 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST Mauro Carvalho Chehab
2014-09-09 18:54 ` [PATCHv3 3/3] [media] vpif: Fix compilation with allmodconfig Mauro Carvalho Chehab
2014-09-09 20:36 ` [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST Guennadi Liakhovetski
2014-09-10 8:04 ` Bartlomiej Zolnierkiewicz
2014-09-10 8:19 ` Bartlomiej Zolnierkiewicz
2014-09-17 3:47 ` linux-next: build failure after merge of the v4l-dvb tree Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60097822.tu6OncvLxQ@wuerfel \
--to=arnd@arndb.de \
--cc=j.anaszewski@samsung.com \
--cc=k.debski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
--cc=s.nawrocki@samsung.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).