From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] leds: pm8058: Make ledtype pointer sized type Date: Thu, 30 Nov 2017 23:02:51 +0100 Message-ID: <661e011e-d7d2-4947-6648-8e76e3426aaa@gmail.com> References: <20171130113516.42c8bde2@canb.auug.org.au> <20171130030543.1071-1-bjorn.andersson@linaro.org> <20171130082940.5mzslaxv53dlu3t2@dell> <20171130083131.kjgehcutqsbkjxr5@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171130083131.kjgehcutqsbkjxr5@dell> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones , Bjorn Andersson Cc: Richard Purdie , Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Stephen Rothwell , Linux-Next Mailing List List-Id: linux-next.vger.kernel.org On 11/30/2017 09:31 AM, Lee Jones wrote: > On Thu, 30 Nov 2017, Lee Jones wrote: > >> On Wed, 29 Nov 2017, Bjorn Andersson wrote: >> >>> The pointer returned by of_device_get_match_data() doesn't have the same >>> size as u32 on 64-bit architectures, causing issues when compile testing >>> the driver on such platform. Make ledtype unsigned long instead, to >>> solve this problem. >>> >>> Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver") >>> Cc: Linus Walleij >>> Signed-off-by: Bjorn Andersson >>> --- >>> drivers/leds/leds-pm8058.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Hi Bjorn, >> >> (Nice to see you) :) >> >> I'm going to apply this *before* Linus' fix. >> >> Applied, thanks. > > After I rx an Ack from Richard, Jacek or Pavel of course. :) > > Will send a pull-request. Huh? This is for LED subsystem AFAICS. -- Best regards, Jacek Anaszewski