linux-next: build warning after merge of the f2fs tree

linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

After merging the f2fs tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  f23307575903 ("f2fs: introduce sb_status sysfs node")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Chao Yu]

Hi Stephen,

On 2021/1/7 11:11, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the f2fs tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.

IIUC, should I remove "/*" and "*/" for newly added entry in sysfs-fs-f2fs?

+What:		/sys/fs/f2fs/<disk>/stat/sb_status
+Date:		December 2020
+Contact:	"Chao Yu" <yuchao0@huawei.com>
+Description:	Show status of f2fs superblock in real time.
+
+		value           sb status macro                 description
+		0x1             SBI_IS_DIRTY,                   /* dirty flag for checkpoint */
+		0x2             SBI_IS_CLOSE,                   /* specify unmounting */
+		0x4             SBI_NEED_FSCK,                  /* need fsck.f2fs to fix */
...

Thanks,

> 
> Introduced by commit
> 
>    f23307575903 ("f2fs: introduce sb_status sysfs node")
> 

Re: linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Chao,

On Thu, 7 Jan 2021 19:28:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:
>
> On 2021/1/7 11:11, Stephen Rothwell wrote:
> > 
> > After merging the f2fs tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.  
> 
> IIUC, should I remove "/*" and "*/" for newly added entry in sysfs-fs-f2fs?

Sorry, I don't know.  Cc'ing Jon.

> 
> +What:		/sys/fs/f2fs/<disk>/stat/sb_status
> +Date:		December 2020
> +Contact:	"Chao Yu" <yuchao0@huawei.com>
> +Description:	Show status of f2fs superblock in real time.
> +
> +		value           sb status macro                 description
> +		0x1             SBI_IS_DIRTY,                   /* dirty flag for checkpoint */
> +		0x2             SBI_IS_CLOSE,                   /* specify unmounting */
> +		0x4             SBI_NEED_FSCK,                  /* need fsck.f2fs to fix */
> ...
> 
> Thanks,
> 
> > 
> > Introduced by commit
> > 
> >    f23307575903 ("f2fs: introduce sb_status sysfs node")
> >   

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Jonathan Corbet]

On Mon, 11 Jan 2021 07:33:54 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> On Thu, 7 Jan 2021 19:28:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:
> >
> > On 2021/1/7 11:11, Stephen Rothwell wrote:  
> > > 
> > > After merging the f2fs tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > > 
> > > Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.    
> > 
> > IIUC, should I remove "/*" and "*/" for newly added entry in sysfs-fs-f2fs?  
> 
> Sorry, I don't know.  Cc'ing Jon.

Removing the comment markers would make the warning go away, but won't
lead to a satisfactory rendering in HTML.  If you want that too, make the
table look like the others immediately above it in the same file.

Thanks,

jon

Re: linux-next: build warning after merge of the f2fs tree

[Chao Yu]

Hi Jonathan,

On 2021/1/11 7:35, Jonathan Corbet wrote:
> On Mon, 11 Jan 2021 07:33:54 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
>> On Thu, 7 Jan 2021 19:28:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:
>>>
>>> On 2021/1/7 11:11, Stephen Rothwell wrote:
>>>>
>>>> After merging the f2fs tree, today's linux-next build (htmldocs) produced
>>>> this warning:
>>>>
>>>> Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.
>>>
>>> IIUC, should I remove "/*" and "*/" for newly added entry in sysfs-fs-f2fs?
>>
>> Sorry, I don't know.  Cc'ing Jon. >
> Removing the comment markers would make the warning go away, but won't
> lead to a satisfactory rendering in HTML.  If you want that too, make the
> table look like the others immediately above it in the same file.

Copied, thanks for your reminder.

I've fixed it and resent the patch:

https://lore.kernel.org/linux-f2fs-devel/20210111075017.82370-1-yuchao0@huawei.com/T/#u

> 
> Thanks,
> 
> jon
> .
> 

Re: linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2273 bytes --]

Hi Chao,

On Mon, 11 Jan 2021 15:54:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:
>
> On 2021/1/11 7:35, Jonathan Corbet wrote:
> > On Mon, 11 Jan 2021 07:33:54 +1100
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >   
> >> On Thu, 7 Jan 2021 19:28:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:  
> >>>
> >>> On 2021/1/7 11:11, Stephen Rothwell wrote:  
> >>>>
> >>>> After merging the f2fs tree, today's linux-next build (htmldocs) produced
> >>>> this warning:
> >>>>
> >>>> Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.  
> >>>
> >>> IIUC, should I remove "/*" and "*/" for newly added entry in sysfs-fs-f2fs?  
> >>
> >> Sorry, I don't know.  Cc'ing Jon. >  
> > Removing the comment markers would make the warning go away, but won't
> > lead to a satisfactory rendering in HTML.  If you want that too, make the
> > table look like the others immediately above it in the same file.  
> 
> Copied, thanks for your reminder.
> 
> I've fixed it and resent the patch:
> 
> https://lore.kernel.org/linux-f2fs-devel/20210111075017.82370-1-yuchao0@huawei.com/T/#u

I am now getting the following::

Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Malformed table.
Text in column margin in table line 15.

=====  ===================== =================================
value  sb status macro       description
0x1    SBI_IS_DIRTY          dirty flag for checkpoint
0x2    SBI_IS_CLOSE          specify unmounting
0x4    SBI_NEED_FSCK         need fsck.f2fs to fix
0x8    SBI_POR_DOING         recovery is doing or not
0x10   SBI_NEED_SB_WRITE     need to recover superblock
0x20   SBI_NEED_CP           need to checkpoint
0x40   SBI_IS_SHUTDOWN       shutdown by ioctl
0x80   SBI_IS_RECOVERED      recovered orphan/data
0x100  SBI_CP_DISABLED       CP was disabled last mount
0x200  SBI_CP_DISABLED_QUICK CP was disabled quickly
0x400  SBI_QUOTA_NEED_FLUSH  need to flush quota info in CP
0x800  SBI_QUOTA_SKIP_FLUSH  skip flushing quota in current CP
0x1000 SBI_QUOTA_NEED_REPAIR quota file may be corrupted
0x2000 SBI_IS_RESIZEFS       resizefs is in process
====== ===================== =================================

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Chao Yu]

Hi Stephen,

On 2021/1/12 13:09, Stephen Rothwell wrote:
> Hi Chao,
> 
> On Mon, 11 Jan 2021 15:54:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:
>>
>> On 2021/1/11 7:35, Jonathan Corbet wrote:
>>> On Mon, 11 Jan 2021 07:33:54 +1100
>>> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>    
>>>> On Thu, 7 Jan 2021 19:28:19 +0800 Chao Yu <yuchao0@huawei.com> wrote:
>>>>>
>>>>> On 2021/1/7 11:11, Stephen Rothwell wrote:
>>>>>>
>>>>>> After merging the f2fs tree, today's linux-next build (htmldocs) produced
>>>>>> this warning:
>>>>>>
>>>>>> Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Inline emphasis start-string without end-string.
>>>>>
>>>>> IIUC, should I remove "/*" and "*/" for newly added entry in sysfs-fs-f2fs?
>>>>
>>>> Sorry, I don't know.  Cc'ing Jon. >
>>> Removing the comment markers would make the warning go away, but won't
>>> lead to a satisfactory rendering in HTML.  If you want that too, make the
>>> table look like the others immediately above it in the same file.
>>
>> Copied, thanks for your reminder.
>>
>> I've fixed it and resent the patch:
>>
>> https://lore.kernel.org/linux-f2fs-devel/20210111075017.82370-1-yuchao0@huawei.com/T/#u
> 
> I am now getting the following::
> 
> Documentation/ABI/testing/sysfs-fs-f2fs:382: WARNING: Malformed table.
> Text in column margin in table line 15.

Oops,

> 
> =====  ===================== =================================

        ^ I guess I missed to type one '=' here....

Thanks,

> value  sb status macro       description
> 0x1    SBI_IS_DIRTY          dirty flag for checkpoint
> 0x2    SBI_IS_CLOSE          specify unmounting
> 0x4    SBI_NEED_FSCK         need fsck.f2fs to fix
> 0x8    SBI_POR_DOING         recovery is doing or not
> 0x10   SBI_NEED_SB_WRITE     need to recover superblock
> 0x20   SBI_NEED_CP           need to checkpoint
> 0x40   SBI_IS_SHUTDOWN       shutdown by ioctl
> 0x80   SBI_IS_RECOVERED      recovered orphan/data
> 0x100  SBI_CP_DISABLED       CP was disabled last mount
> 0x200  SBI_CP_DISABLED_QUICK CP was disabled quickly
> 0x400  SBI_QUOTA_NEED_FLUSH  need to flush quota info in CP
> 0x800  SBI_QUOTA_SKIP_FLUSH  skip flushing quota in current CP
> 0x1000 SBI_QUOTA_NEED_REPAIR quota file may be corrupted
> 0x2000 SBI_IS_RESIZEFS       resizefs is in process
> ====== ===================== =================================
> 

Re: linux-next: build warning after merge of the f2fs tree

[Jaegeuk Kim]

On 03/03, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the f2fs tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/f2fs/sysfs.c:576:25: warning: 'f2fs_attr_ovp_segments' defined but not used [-Wunused-variable]
>   576 | static struct f2fs_attr f2fs_attr_##name = __ATTR(name, 0444, name##_show, NULL)
>       |                         ^~~~~~~~~~
> fs/f2fs/sysfs.c:639:1: note: in expansion of macro 'F2FS_GENERAL_RO_ATTR'
>   639 | F2FS_GENERAL_RO_ATTR(ovp_segments);
>       | ^~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   10e0b8ef8715 ("f2fs: expose # of overprivision segments")

Thanks. Should be fixed soon.

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Hi all,

After merging the f2fs tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/f2fs/sysfs.c:576:25: warning: 'f2fs_attr_ovp_segments' defined but not used [-Wunused-variable]
  576 | static struct f2fs_attr f2fs_attr_##name = __ATTR(name, 0444, name##_show, NULL)
      |                         ^~~~~~~~~~
fs/f2fs/sysfs.c:639:1: note: in expansion of macro 'F2FS_GENERAL_RO_ATTR'
  639 | F2FS_GENERAL_RO_ATTR(ovp_segments);
      | ^~~~~~~~~~~~~~~~~~~~

Introduced by commit

  10e0b8ef8715 ("f2fs: expose # of overprivision segments")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Hi Jaegeuk,

On Mon, 26 Nov 2018 14:22:57 -0800 Jaegeuk Kim <jaegeuk@kernel.org> wrote:
>
> Is this okay?

That looks great, thanks.

> From: Jaegeuk Kim <jaegeuk@kernel.org>
> Date: Mon, 26 Nov 2018 14:20:32 -0800
> Subject: [PATCH] f2fs: avoid build warn of fall_through
> 
> After merging the f2fs tree, today's linux-next build
>  (x86_64_allmodconfig) produced this warning:
> 
>  In file included from fs/f2fs/dir.c:11:
>  fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
>  fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     if (set)
>        ^
>  fs/f2fs/f2fs.h:2390:2: note: here
>    case FI_DATA_EXIST:
>    ^~~~
> 
>  Exposed by my use of -Wimplicit-fallthrough
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/f2fs.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 26ad1de8641c..b3fe6803d4c6 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
>  	case FI_NEW_INODE:
>  		if (set)
>  			return;
> +		/* fall through */
>  	case FI_DATA_EXIST:
>  	case FI_INLINE_DOTS:
>  	case FI_PIN_FILE:
> -- 

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Gustavo A. R. Silva]

On 11/26/18 4:22 PM, Jaegeuk Kim wrote:
> On 11/27, Stephen Rothwell wrote:
[..]
> 
> Oh, thanks~
> Is this okay?
> 

Yep. This fix the warning. :)

Thanks, Jaegeuk
--
Gustavo

>  From 79e24f1509e5b6a07069be9cc8163969da78c57a Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk@kernel.org>
> Date: Mon, 26 Nov 2018 14:20:32 -0800
> Subject: [PATCH] f2fs: avoid build warn of fall_through
> 
> After merging the f2fs tree, today's linux-next build
>   (x86_64_allmodconfig) produced this warning:
> 
>   In file included from fs/f2fs/dir.c:11:
>   fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
>   fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>      if (set)
>         ^
>   fs/f2fs/f2fs.h:2390:2: note: here
>     case FI_DATA_EXIST:
>     ^~~~
> 
>   Exposed by my use of -Wimplicit-fallthrough
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>   fs/f2fs/f2fs.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 26ad1de8641c..b3fe6803d4c6 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
>   	case FI_NEW_INODE:
>   		if (set)
>   			return;
> +		/* fall through */
>   	case FI_DATA_EXIST:
>   	case FI_INLINE_DOTS:
>   	case FI_PIN_FILE:
> 

Re: linux-next: build warning after merge of the f2fs tree

[Jaegeuk Kim]

On 11/27, Stephen Rothwell wrote:
> Hi Jaegeuk,
> 
> On Mon, 26 Nov 2018 13:59:24 -0800 Jaegeuk Kim <jaegeuk@kernel.org> wrote:
> >
> > On 11/26, Stephen Rothwell wrote:
> > > 
> > > After merging the f2fs tree, today's linux-next build
> > > (x86_64_allmodconfig) produced this warning:
> > > 
> > > In file included from fs/f2fs/dir.c:11:
> > > fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
> > > fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > >    if (set)
> > >       ^
> > > fs/f2fs/f2fs.h:2390:2: note: here
> > >   case FI_DATA_EXIST:
> > >   ^~~~
> > > 
> > > Exposed by my use of -Wimplicit-fallthrough
> > > 
> > > I am not sure why this has turned up now (as opposed to earlier today).  
> > 
> > The above change had been there for a long time, as an intended behavior.
> 
> Yeah, it popped up due to line number changes in that file and the way
> I was filtering new warnings.
> 
> > Hmm, I'm not sure how to avoid this.
> 
> if you add a comment
> 	/* fall through */
> at the point the fall through occurs, then the warning is suppressed
> (and it documents that it is deliberate).

Oh, thanks~
Is this okay?

>From 79e24f1509e5b6a07069be9cc8163969da78c57a Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim <jaegeuk@kernel.org>
Date: Mon, 26 Nov 2018 14:20:32 -0800
Subject: [PATCH] f2fs: avoid build warn of fall_through

After merging the f2fs tree, today's linux-next build
 (x86_64_allmodconfig) produced this warning:

 In file included from fs/f2fs/dir.c:11:
 fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
 fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (set)
       ^
 fs/f2fs/f2fs.h:2390:2: note: here
   case FI_DATA_EXIST:
   ^~~~

 Exposed by my use of -Wimplicit-fallthrough

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/f2fs.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 26ad1de8641c..b3fe6803d4c6 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
 	case FI_NEW_INODE:
 		if (set)
 			return;
+		/* fall through */
 	case FI_DATA_EXIST:
 	case FI_INLINE_DOTS:
 	case FI_PIN_FILE:
-- 
2.19.0.605.g01d371f741-goog

Re: linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

Hi Jaegeuk,

On Mon, 26 Nov 2018 13:59:24 -0800 Jaegeuk Kim <jaegeuk@kernel.org> wrote:
>
> On 11/26, Stephen Rothwell wrote:
> > 
> > After merging the f2fs tree, today's linux-next build
> > (x86_64_allmodconfig) produced this warning:
> > 
> > In file included from fs/f2fs/dir.c:11:
> > fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
> > fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >    if (set)
> >       ^
> > fs/f2fs/f2fs.h:2390:2: note: here
> >   case FI_DATA_EXIST:
> >   ^~~~
> > 
> > Exposed by my use of -Wimplicit-fallthrough
> > 
> > I am not sure why this has turned up now (as opposed to earlier today).  
> 
> The above change had been there for a long time, as an intended behavior.

Yeah, it popped up due to line number changes in that file and the way
I was filtering new warnings.

> Hmm, I'm not sure how to avoid this.

if you add a comment
	/* fall through */
at the point the fall through occurs, then the warning is suppressed
(and it documents that it is deliberate).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Jaegeuk Kim]

Hi Stephen,

On 11/26, Stephen Rothwell wrote:
> Hi Jaegeuk,
> 
> After merging the f2fs tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> 
> In file included from fs/f2fs/dir.c:11:
> fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
> fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (set)
>       ^
> fs/f2fs/f2fs.h:2390:2: note: here
>   case FI_DATA_EXIST:
>   ^~~~
> 
> Exposed by my use of -Wimplicit-fallthrough
> 
> I am not sure why this has turned up now (as opposed to earlier today).

The above change had been there for a long time, as an intended behavior.
Hmm, I'm not sure how to avoid this.

Thanks,

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Hi Jaegeuk,

After merging the f2fs tree, today's linux-next build
(x86_64_allmodconfig) produced this warning:

In file included from fs/f2fs/dir.c:11:
fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (set)
      ^
fs/f2fs/f2fs.h:2390:2: note: here
  case FI_DATA_EXIST:
  ^~~~

Exposed by my use of -Wimplicit-fallthrough

I am not sure why this has turned up now (as opposed to earlier today).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the f2fs tree

[Jaegeuk Kim]

Thank you.
Worked around that in the dev branch.

On 02/10, Stephen Rothwell wrote:
> Hi Jaegeuk,
> 
> After merging the f2fs tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> 
> fs/f2fs/node.c: In function 'fsync_node_pages':
> fs/f2fs/node.c:1520:3: warning: 'last_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    f2fs_submit_merged_bio_cond(sbi, NULL, ino, last_idx,
>    ^
> 
> Introduced by commit
> 
>   9563642a6ec2 ("f2fs: check last page index in cached bio to decide submission")
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the f2fs tree

[Stephen Rothwell]

Hi Jaegeuk,

After merging the f2fs tree, today's linux-next build
(x86_64_allmodconfig) produced this warning:

fs/f2fs/node.c: In function 'fsync_node_pages':
fs/f2fs/node.c:1520:3: warning: 'last_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
   f2fs_submit_merged_bio_cond(sbi, NULL, ino, last_idx,
   ^

Introduced by commit

  9563642a6ec2 ("f2fs: check last page index in cached bio to decide submission")

-- 
Cheers,
Stephen Rothwell