From: Randy Dunlap <rdunlap@infradead.org>
To: Nick Crews <ncrews@chromium.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>
Subject: Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)
Date: Tue, 12 Feb 2019 16:13:54 -0800 [thread overview]
Message-ID: <6913db72-85b3-0b7d-5e38-9cbb6ec4c8c2@infradead.org> (raw)
In-Reply-To: <CAHX4x87nRpTR5880y6hc=r7k0OFV9YKate21U=2kkqC-ihdmCQ@mail.gmail.com>
On 2/12/19 3:49 PM, Nick Crews wrote:
> OK, here is the patch to fix this problem. We had the dependency backwards.
>
> Should I re-send out the entire patch series to the LKML with this fix in it?
>
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index 462eb9dfa4f2..b69561050868 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -95,7 +95,7 @@ config CROS_EC_LPC
>
> config CROS_EC_LPC_MEC
> bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant"
> - depends on CROS_EC_LPC || WILCO_EC
> + depends on CROS_EC_LPC
> default n
> help
> If you say Y here, a variant LPC protocol for the Microchip EC
> diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
> index d8e2cddb4712..6ea2d3f64ce5 100644
> --- a/drivers/platform/chrome/wilco_ec/Kconfig
> +++ b/drivers/platform/chrome/wilco_ec/Kconfig
> @@ -1,6 +1,6 @@
> config WILCO_EC
> tristate "ChromeOS Wilco Embedded Controller"
> - depends on ACPI && X86
> + depends on ACPI && X86 && CROS_EC_LPC_MEC
> select CROS_EC_LPC_MEC
> help
> If you say Y here, you get support for talking to the ChromeOS
>
>
Nick,
Did you test this?
When I apply the patch (by hand, since it was whitespace-mangled/damaged),
I get this:
rdunlap@midway:linux-next-20190212> make ARCH=x86_64 O=X64 oldconfig
make[1]: Entering directory '/home/rdunlap/lnx/next/linux-next-20190212/X64'
GEN Makefile
scripts/kconfig/conf --oldconfig Kconfig
drivers/platform/chrome/Kconfig:84:error: recursive dependency detected!
drivers/platform/chrome/Kconfig:84: symbol CROS_EC_LPC_MEC is selected by WILCO_EC
drivers/platform/chrome/wilco_ec/Kconfig:1: symbol WILCO_EC depends on CROS_EC_LPC_MEC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
--
~Randy
next prev parent reply other threads:[~2019-02-13 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 6:50 linux-next: Tree for Feb 12 Stephen Rothwell
2019-02-12 16:44 ` linux-next: Tree for Feb 12 (chrome/wilco_ec/) Randy Dunlap
[not found] ` <CAHX4x87=Myx45wBYtFY=rwz8jVmYY-tYVQjnzod-V8HaWJSy+g@mail.gmail.com>
2019-02-12 23:31 ` Randy Dunlap
[not found] ` <CAHX4x87nRpTR5880y6hc=r7k0OFV9YKate21U=2kkqC-ihdmCQ@mail.gmail.com>
2019-02-13 0:04 ` Randy Dunlap
2019-02-13 0:13 ` Randy Dunlap [this message]
2019-02-13 17:26 ` Nick Crews
2019-02-13 21:29 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6913db72-85b3-0b7d-5e38-9cbb6ec4c8c2@infradead.org \
--to=rdunlap@infradead.org \
--cc=dlaurie@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).