From: John Hubbard <jhubbard@nvidia.com>
To: Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andriin@fb.com>
Cc: Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
<bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] bpf: fix a no-mmu build failure by providing a stub allocator
Date: Mon, 25 Nov 2019 15:45:17 -0800 [thread overview]
Message-ID: <735f27ed-65dd-d132-e6b4-20ba5749876c@nvidia.com> (raw)
In-Reply-To: <8c4d892a-73b5-b4d5-be15-bc81e8297de9@iogearbox.net>
On 11/25/19 3:43 PM, Daniel Borkmann wrote:
> On 11/26/19 12:41 AM, John Hubbard wrote:
>> Commit fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
>> added code that calls vmalloc_user_node_flags() and therefore requires
>> mm/vmalloc.c. However, that file is not built for the !CONFIG_MMU case.
>> This leads to a build failure when using ARM with the config provided
>> by at least one particular kbuild test robot report [1].
>>
>> [1] https://lore/kernel.org/r/201911251639.UWS3hE3Y%lkp@intel.com
>>
>> Fix the build by providing a stub function for __bpf_map_area_alloc().
>>
>> Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Cc: Andrii Nakryiko <andriin@fb.com>
>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>> Cc: Song Liu <songliubraving@fb.com>
>> Cc: John Fastabend <john.fastabend@gmail.com>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>
> Thanks for the patch, already fixed via:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=ed81745a4c96841937f1da35c0eb66ac312e1480
OK, good, that's a better fix, too. Appreciate the quick answers!
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2019-11-25 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 23:41 [PATCH 0/1] bpf: fix a no-mmu build failure by providing a stub allocator John Hubbard
2019-11-25 23:41 ` [PATCH] " John Hubbard
2019-11-25 23:43 ` Daniel Borkmann
2019-11-25 23:45 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=735f27ed-65dd-d132-e6b4-20ba5749876c@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).