From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhananjay Phadke Subject: RE: [PATCH -next] netxen: fix build when CONFIG_INET=n Date: Tue, 28 Jul 2009 11:25:19 -0700 Message-ID: <7608421F3572AB4292BB2532AE89D5658187610C1C@AVEXMB1.qlogic.org> References: <20090728174224.647cc3ba.sfr@canb.auug.org.au>,<20090728112103.81f229d6.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from avexch1.qlogic.com ([198.70.193.115]:42778 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390AbZG1S2L convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2009 14:28:11 -0400 In-Reply-To: <20090728112103.81f229d6.randy.dunlap@oracle.com> Content-Language: en-US Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap , Stephen Rothwell , "davem@davemloft.net" Cc: "linux-next@vger.kernel.org" , LKML , netdev Thanks Randy for catching, I didn't run CONFIG_INET=n build. I think, better option is to wrap code in netxen_nic_main.c with CONFIG_INET check, since it's not a mandatory feature. -Dhananjay ________________________________________ From: Randy Dunlap [randy.dunlap@oracle.com] Sent: Tuesday, July 28, 2009 11:21 AM To: Stephen Rothwell; davem@davemloft.net Cc: linux-next@vger.kernel.org; LKML; netdev; Dhananjay Phadke Subject: [PATCH -next] netxen: fix build when CONFIG_INET=n From: Randy Dunlap Fix netxen build errors when CONFIG_INET=n: netxen_nic_main.c:(.text+0x1abb8a): undefined reference to `in_dev_finish_destroy' netxen_nic_main.c:(.init.text+0xd86e): undefined reference to `register_inetaddr_notifier' netxen_nic_main.c:(.exit.text+0x1b70): undefined reference to `unregister_inetaddr_notifier' Signed-off-by: Randy Dunlap Cc: Dhananjay Phadke --- drivers/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090728.orig/drivers/net/Kconfig +++ linux-next-20090728/drivers/net/Kconfig @@ -2666,7 +2666,7 @@ config MYRI10GE_DCA config NETXEN_NIC tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" - depends on PCI + depends on PCI && INET help This enables the support for NetXen's Gigabit Ethernet card. --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/