Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>
Subject: Re: linux-next: Tree for Apr 9 (x86 boot problem)
Date: Tue, 13 Apr 2021 10:34:25 -0700
Message-ID: <7bc072c0-bf10-bd0f-95db-0f0a7db47b93@infradead.org> (raw)
In-Reply-To: <YHXNyVVUwZbVDBrr@kernel.org>

On 4/13/21 9:58 AM, Mike Rapoport wrote:
> On Mon, Apr 12, 2021 at 11:21:48PM -0700, Randy Dunlap wrote:
>> On 4/12/21 11:06 PM, Mike Rapoport wrote:
>>> Hi Randy,
>>>
>>> On Mon, Apr 12, 2021 at 01:53:34PM -0700, Randy Dunlap wrote:
>>>> On 4/12/21 10:01 AM, Mike Rapoport wrote:
>>>>> On Mon, Apr 12, 2021 at 08:49:49AM -0700, Randy Dunlap wrote:
>>>>>  
>>>>> I thought about adding some prints to see what's causing the hang, the
>>>>> reservations or their absence. Can you replace the debug patch with this
>>>>> one:
>>>>>
>>>>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>>>>> index 776fc9b3fafe..a10ac252dbcc 100644
>>>>> --- a/arch/x86/kernel/setup.c
>>>>> +++ b/arch/x86/kernel/setup.c
>>>>> @@ -600,10 +600,13 @@ static bool __init snb_gfx_workaround_needed(void)
>>>>>  		return false;
>>>>>  
>>>>>  	vendor = read_pci_config_16(0, 2, 0, PCI_VENDOR_ID);
>>>>> +	devid = read_pci_config_16(0, 2, 0, PCI_DEVICE_ID);
>>>>> +
>>>>> +	pr_info("%s: vendor: %x, device: %x\n", __func__, vendor, device);
>>>>
>>>> s/device)/devid)/
>>>  
>>> Oh, sorry.
>>>
>>>>> +
>>>>>  	if (vendor != 0x8086)
>>>>>  		return false;
>>>>>  
>>>>> -	devid = read_pci_config_16(0, 2, 0, PCI_DEVICE_ID);
>>>>>  	for (i = 0; i < ARRAY_SIZE(snb_ids); i++)
>>>>>  		if (devid == snb_ids[i])
>>>>>  			return true;
>>>>
>>>> That prints:
>>>>
>>>> [    0.000000] snb_gfx_workaround_needed: vendor: 8086, device: 126
>>>> [    0.000000] early_reserve_memory: snb_gfx: 1
>>>> ...
>>>> [    0.014061] snb_gfx_workaround_needed: vendor: 8086, device: 126
>>>> [    0.014064] reserving inaccessible SNB gfx pages
>>>>
>>>>
>>>> The full boot log is attached.
>>>  
>>> Can you please send the log with memblock=debug added to the kernel command
>>> line?
>>>
>>> Probably should have started from this...
>>>
>>
>> It's attached.
> 
> Honestly, I can't see any reason why moving these reservations around would
> cause your laptop to hang.
> Let's try moving the reservations back to their original place one by
> one, e.g something like this:
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 776fc9b3fafe..892ad20b8557 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -632,12 +632,6 @@ static void __init trim_snb_memory(void)
>  
>  	printk(KERN_DEBUG "reserving inaccessible SNB gfx pages\n");
>  
> -	/*
> -	 * Reserve all memory below the 1 MB mark that has not
> -	 * already been reserved.
> -	 */
> -	memblock_reserve(0, 1<<20);
> -	
>  	for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
>  		if (memblock_reserve(bad_pages[i], PAGE_SIZE))
>  			printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -1081,6 +1075,12 @@ void __init setup_arch(char **cmdline_p)
>  
>  	reserve_real_mode();
>  
> +	/*
> +	 * Reserve all memory below the 1 MB mark that has not
> +	 * already been reserved.
> +	 */
> +	memblock_reserve(0, 1<<20);
> +
>  	init_mem_mapping();
>  
>  	idt_setup_early_pf();
> 

Mike,
That works.

Please send the next test.

-- 
~Randy


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 11:51 linux-next: Tree for Apr 9 Stephen Rothwell
2021-04-10 23:50 ` linux-next: Tree for Apr 9 (drivers/iommu/intel/pasid.c) Randy Dunlap
2021-04-12  2:41 ` linux-next: Tree for Apr 9 (x86 boot problem) Randy Dunlap
2021-04-12  6:14   ` Mike Rapoport
2021-04-12 15:49     ` Randy Dunlap
2021-04-12 17:01       ` Mike Rapoport
2021-04-12 20:53         ` Randy Dunlap
2021-04-13  6:06           ` Mike Rapoport
2021-04-13  6:21             ` Randy Dunlap
2021-04-13 16:58               ` Mike Rapoport
2021-04-13 17:34                 ` Randy Dunlap [this message]
2021-04-13 18:23                   ` Mike Rapoport
2021-04-13 19:07                     ` Randy Dunlap
2021-04-13 19:09                     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bc072c0-bf10-bd0f-95db-0f0a7db47b93@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git