From: Saeed Mahameed <saeedm@mellanox.com>
To: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
Eran Ben Elisha <eranbe@mellanox.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
haiyangz <haiyangz@microsoft.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: linux-next: Tree for Aug 29 (mlx5)
Date: Thu, 29 Aug 2019 23:04:09 +0000 [thread overview]
Message-ID: <82c4fad3fc394693a596597df0d73cc5235f7025.camel@mellanox.com> (raw)
In-Reply-To: <DM6PR21MB13379A89D3A57DCFD6E0D419CAA20@DM6PR21MB1337.namprd21.prod.outlook.com>
On Thu, 2019-08-29 at 21:48 +0000, Haiyang Zhang wrote:
> > -----Original Message-----
> > From: Saeed Mahameed <saeedm@mellanox.com>
> > Sent: Thursday, August 29, 2019 2:32 PM
> > To: sfr@canb.auug.org.au; Eran Ben Elisha <eranbe@mellanox.com>;
> > linux-
> > next@vger.kernel.org; rdunlap@infradead.org; Haiyang Zhang
> > <haiyangz@microsoft.com>
> > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; Leon
> > Romanovsky <leonro@mellanox.com>
> > Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> >
> > On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> > > On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > > > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Changes since 20190828:
> > > > >
> > > >
> > > > on x86_64:
> > > > when CONFIG_PCI_HYPERV=m
> > >
> > > and CONFIG_PCI_HYPERV_INTERFACE=m
> > >
> >
> > Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
> > supposed to be a module ? it supposed to provide an always
> > available
> > interface to drivers ..
> >
> > Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5.
>
> The symbolic dependency by driver mlx5e, automatically triggers
> loading of
> pci_hyperv_interface module. And this module can be loaded in any
> platforms.
>
This only works when both are modules.
> Currently, mlx5e driver has #if
> IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE)
> around the code using the interface.
>
> I agree --
> Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these
> #if's.
>
No, not "select", "imply".
if one wants PCI_HYPERV_INTERFACE off, imply will keep it off for you.
> Thanks,
> - Haiyang
next prev parent reply other threads:[~2019-08-29 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 11:08 linux-next: Tree for Aug 29 Stephen Rothwell
2019-08-29 19:54 ` linux-next: Tree for Aug 29 (mlx5) Randy Dunlap
2019-08-29 19:55 ` Randy Dunlap
2019-08-29 21:31 ` Saeed Mahameed
2019-08-29 21:48 ` Haiyang Zhang
2019-08-29 23:04 ` Saeed Mahameed [this message]
2019-08-29 23:15 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82c4fad3fc394693a596597df0d73cc5235f7025.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=eranbe@mellanox.com \
--cc=haiyangz@microsoft.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).