linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the drivers-memory tree
Date: Mon, 9 Nov 2020 04:01:37 +0300	[thread overview]
Message-ID: <82fd8221-f903-2646-4b00-a20ae936ff25@gmail.com> (raw)
In-Reply-To: <20201109102300.539961bb@canb.auug.org.au>

09.11.2020 02:23, Stephen Rothwell пишет:
> Hi all,
> 
> After merging the drivers-memory tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/devfreq/tegra20-devfreq.c:18:
> include/soc/tegra/mc.h: In function 'devm_tegra_memory_controller_get':
> include/soc/tegra/mc.h:211:1: error: no return statement in function returning non-void [-Werror=return-type]
>   211 | }
>       | ^
> 
> Caused by commit
> 
>   1f1997eb44b1 ("memory: tegra: Add and use devm_tegra_memory_controller_get()")
> 
> I have added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 9 Nov 2020 10:19:44 +1100
> Subject: [PATCH] fix "memory: tegra: Add and use
>  devm_tegra_memory_controller_get()"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/soc/tegra/mc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
> index 43876216de34..d731407e23bb 100644
> --- a/include/soc/tegra/mc.h
> +++ b/include/soc/tegra/mc.h
> @@ -207,7 +207,7 @@ struct tegra_mc *devm_tegra_memory_controller_get(struct device *dev);
>  static inline struct tegra_mc *
>  devm_tegra_memory_controller_get(struct device *dev)
>  {
> -	ERR_PTR(-ENODEV);
> +	return ERR_PTR(-ENODEV);
>  }
>  #endif

Krzysztof, will you be able correct this typo locally, or should I add a
new patch?

  reply	other threads:[~2020-11-09  1:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 23:23 linux-next: build failure after merge of the drivers-memory tree Stephen Rothwell
2020-11-09  1:01 ` Dmitry Osipenko [this message]
2020-11-09  8:04   ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2020-07-27 11:36 Stephen Rothwell
2020-07-27 11:49 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82fd8221-f903-2646-4b00-a20ae936ff25@gmail.com \
    --to=digetx@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).