From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B404DC7EE2F for ; Tue, 6 Jun 2023 07:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236064AbjFFHvd (ORCPT ); Tue, 6 Jun 2023 03:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237418AbjFFHuf (ORCPT ); Tue, 6 Jun 2023 03:50:35 -0400 X-Greylist: delayed 429 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 06 Jun 2023 00:46:57 PDT Received: from smtp-bc09.mail.infomaniak.ch (smtp-bc09.mail.infomaniak.ch [IPv6:2001:1600:3:17::bc09]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05F1AE69 for ; Tue, 6 Jun 2023 00:46:56 -0700 (PDT) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Qb2Ry67wKzMpnwc; Tue, 6 Jun 2023 09:39:42 +0200 (CEST) Received: from unknown by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4Qb2Rx40x2zMpnPq; Tue, 6 Jun 2023 09:39:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1686037182; bh=onTta4zxo0KV8FXnJJ+OInrN8UxvhAaHFZ59RIsmfNQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GQai/YRhFBXDORxGP9qJQq+pkLNrelXG8jSLYrAykI1G8djZXzHNAQEjVMw7x2EGv TJFhvjQUORXr/QZSCBdXkIdXBS1FzoP02XnPvYn9ProLlCKy934elHSAGsBzAyH3JK r8hci6yT+sayaMvs/fgtZwo/byIW3c+txCh43B+0= Message-ID: <86217436-e3aa-00b6-ec0e-947ac249db3a@digikod.net> Date: Tue, 6 Jun 2023 09:39:39 +0200 MIME-Version: 1.0 User-Agent: Subject: Re: linux-next: build failure after merge of the landlock tree Content-Language: en-US To: Stephen Rothwell Cc: Konstantin Meskhidze , Linux Kernel Mailing List , Linux Next Mailing List References: <20230606130236.4d339a46@canb.auug.org.au> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: <20230606130236.4d339a46@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hi Stephen, I only checked this branch with a previous kernel version. It is now fixed and pushed. Thanks, Mickaël On 06/06/2023 05:02, Stephen Rothwell wrote: > Hi all, > > After merging the landlock tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > security/landlock/net.c:165:51: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__lsm_ro_after_init' > 165 | static struct security_hook_list landlock_hooks[] __lsm_ro_after_init = { > | ^~~~~~~~~~~~~~~~~~~ > security/landlock/net.c: In function 'landlock_add_net_hooks': > security/landlock/net.c:172:28: error: 'landlock_hooks' undeclared (first use in this function) > 172 | security_add_hooks(landlock_hooks, ARRAY_SIZE(landlock_hooks), > | ^~~~~~~~~~~~~~ > security/landlock/net.c:172:28: note: each undeclared identifier is reported only once for each function it appears in > In file included from include/linux/container_of.h:5, > from include/linux/kernel.h:21, > from include/linux/uio.h:8, > from include/linux/socket.h:8, > from include/uapi/linux/in.h:25, > from include/linux/in.h:19, > from security/landlock/net.c:9: > include/linux/build_bug.h:16:51: error: bit-field '' width not an integer constant > 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) > | ^ > include/linux/compiler.h:231:33: note: in expansion of macro 'BUILD_BUG_ON_ZERO' > 231 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) > | ^~~~~~~~~~~~~~~~~ > include/linux/kernel.h:56:59: note: in expansion of macro '__must_be_array' > 56 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) > | ^~~~~~~~~~~~~~~ > security/landlock/net.c:172:44: note: in expansion of macro 'ARRAY_SIZE' > 172 | security_add_hooks(landlock_hooks, ARRAY_SIZE(landlock_hooks), > | ^~~~~~~~~~ > security/landlock/net.c: At top level: > security/landlock/net.c:157:12: warning: 'hook_socket_connect' defined but not used [-Wunused-function] > 157 | static int hook_socket_connect(struct socket *const sock, > | ^~~~~~~~~~~~~~~~~~~ > security/landlock/net.c:150:12: warning: 'hook_socket_bind' defined but not used [-Wunused-function] > 150 | static int hook_socket_bind(struct socket *const sock, > | ^~~~~~~~~~~~~~~~ > > Caused by commit > > 6d0bfdb25ce6 ("landlock: Add network rules and TCP hooks support") > > I have use the landlock tree from next-20230605 for today. >