From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CF1C77B60 for ; Wed, 26 Apr 2023 05:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239432AbjDZF7l (ORCPT ); Wed, 26 Apr 2023 01:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjDZF7k (ORCPT ); Wed, 26 Apr 2023 01:59:40 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA5D2681; Tue, 25 Apr 2023 22:59:36 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1prYBY-0003p8-9c; Wed, 26 Apr 2023 07:59:24 +0200 Message-ID: <872f3ba1-1771-2ef4-1353-4cadd92eb5e1@leemhuis.info> Date: Wed, 26 Apr 2023 07:59:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree) Content-Language: en-US, de-DE To: Dave Airlie , DRI Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , =?UTF-8?Q?Christian_K=c3=b6nig?= , Linux Kernel Mailing List , Linux Next Mailing List , Linux kernel regressions list , Justin Forbes , Stephen Rothwell References: <20230411164714.2ce79bcb@canb.auug.org.au> From: Thorsten Leemhuis In-Reply-To: <20230411164714.2ce79bcb@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1682488776;d38ea619; X-HE-SMSGID: 1prYBY-0003p8-9c Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Lo! Sometimes the regression tracker runs into regressions himself... :-D On 11.04.23 08:47, Stephen Rothwell wrote: > > After merging the drm tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope > 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER]; > | ^~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified 'global_uncached' at file scope > 74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER]; > | ^~~~~~~~~~~~~~~ > drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified 'global_dma32_write_combined' at file scope > 76 | static struct ttm_pool_type global_dma32_write_combined[TTM_DIM_ORDER]; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified 'global_dma32_uncached' at file scope > 77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER]; > | ^~~~~~~~~~~~~~~~~~~~~ > > Caused by commit > > 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages") > > PMD_SHIFT is not necessarily a constant on ppc (see > arch/powerpc/include/asm/book3s/64/pgtable.h). > > I have reverted that commit for today. Did anyone look into this? I today ran into what looks like the same compiler error when building a mainline snapshot using a Fedora rawhide config for ppc64le: ``` drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER]; | ^~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified 'global_uncached' at file scope 74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER]; | ^~~~~~~~~~~~~~~ drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified 'global_dma32_write_combined' at file scope 76 | static struct ttm_pool_type global_dma32_write_combined[TTM_DIM_ORDER]; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified 'global_dma32_uncached' at file scope 77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER]; | ^~~~~~~~~~~~~~~~~~~~~ ``` Full build log: https://copr-be.cloud.fedoraproject.org/results/@kernel-vanilla/mainline/fedora-37-ppc64le/05850588-mainline-mainline-releases/build.log.gz Ciao, Thorsten