From: Takashi Iwai <tiwai@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Takashi Iwai <tiwai@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the sound tree
Date: Wed, 24 May 2023 09:14:34 +0200 [thread overview]
Message-ID: <87353mfbfp.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230524135448.3ecad334@canb.auug.org.au>
On Wed, 24 May 2023 05:54:48 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from sound/core/seq/seq_ump_convert.c:11:
> include/sound/ump_msg.h:196:13: error: duplicate member 'reserved'
> 196 | u32 reserved:8;
> | ^~~~~~~~
> include/sound/ump_msg.h:197:13: error: duplicate member 'program'
> 197 | u32 program:8;
> | ^~~~~~~
> include/sound/ump_msg.h:198:13: error: duplicate member 'channel'
> 198 | u32 channel:4;
> | ^~~~~~~
> include/sound/ump_msg.h:199:13: error: duplicate member 'status'
> 199 | u32 status:4;
> | ^~~~~~
> include/sound/ump_msg.h:200:13: error: duplicate member 'group'
> 200 | u32 group:4;
> | ^~~~~
> include/sound/ump_msg.h:201:13: error: duplicate member 'type'
> 201 | u32 type:4;
> | ^~~~
>
> Caused by commit
>
> 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
>
> I have applied the following fix patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 24 May 2023 13:39:38 +1000
> Subject: [PATCH] fix up for "ALSA: ump: Add legacy raw MIDI support"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Thanks! This was a late change and I have skipped testing big-endian
since then, as it seems...
I queued up your fix patch.
Takashi
> ---
> include/sound/ump_msg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/sound/ump_msg.h b/include/sound/ump_msg.h
> index c76c39944a5f..a594ef951b54 100644
> --- a/include/sound/ump_msg.h
> +++ b/include/sound/ump_msg.h
> @@ -192,13 +192,13 @@ struct snd_ump_midi1_msg_program {
> u32 program:8;
> u32 reserved:8;
> #else
> -#endif
> u32 reserved:8;
> u32 program:8;
> u32 channel:4;
> u32 status:4;
> u32 group:4;
> u32 type:4;
> +#endif
> } __packed;
>
> /* MIDI 1.0 Channel Pressure (32bit) */
> --
> 2.39.2
>
> --
> Cheers,
> Stephen Rothwell
next prev parent reply other threads:[~2023-05-24 7:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 3:54 linux-next: build failure after merge of the sound tree Stephen Rothwell
2023-05-24 7:14 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 3:12 Stephen Rothwell
2023-08-18 11:47 ` Takashi Iwai
2022-07-15 12:44 Stephen Rothwell
2022-07-15 14:41 ` Takashi Iwai
2022-07-15 19:09 ` Andy Shevchenko
2021-10-18 0:38 Stephen Rothwell
2021-10-18 6:35 ` Takashi Iwai
2020-07-17 3:01 Stephen Rothwell
2020-07-17 5:33 ` Christoph Hellwig
2020-07-17 6:34 ` Takashi Iwai
2020-07-17 6:50 ` Christoph Hellwig
2020-07-17 6:54 ` Takashi Iwai
2019-08-09 2:54 Stephen Rothwell
2019-08-09 5:55 ` Takashi Iwai
2017-05-17 1:29 Stephen Rothwell
2017-05-17 5:30 ` Takashi Iwai
2011-09-23 2:49 Stephen Rothwell
2011-09-23 5:21 ` Takashi Iwai
2011-05-19 1:15 Stephen Rothwell
2010-09-23 2:44 Stephen Rothwell
2010-09-23 6:04 ` Takashi Iwai
2010-09-23 8:39 ` Mark Brown
2010-06-24 3:03 Stephen Rothwell
2010-06-24 6:11 ` Takashi Iwai
2010-06-28 16:33 ` Daniel Mack
2010-06-01 2:30 Stephen Rothwell
2010-06-01 5:47 ` Takashi Iwai
2010-04-07 3:39 Stephen Rothwell
2010-04-07 6:06 ` Takashi Iwai
2010-04-07 7:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87353mfbfp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).