From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D83EFC43603 for ; Wed, 18 Dec 2019 10:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA7FC218AC for ; Wed, 18 Dec 2019 10:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbfLRKaZ (ORCPT ); Wed, 18 Dec 2019 05:30:25 -0500 Received: from mga12.intel.com ([192.55.52.136]:57954 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbfLRKaZ (ORCPT ); Wed, 18 Dec 2019 05:30:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 02:30:24 -0800 X-IronPort-AV: E=Sophos;i="5.69,329,1571727600"; d="scan'208";a="210047542" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 02:30:20 -0800 From: Jani Nikula To: Sam Ravnborg , Randy Dunlap Cc: Stephen Rothwell , dri-devel@lists.freedesktop.org, David Airlie , Thierry Reding , Linux Next Mailing List , Andy Shevchenko , Sean Paul , Laurent Pinchart Subject: Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time In-Reply-To: <20191217194058.GA30852@ravnborg.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191217140721.42432-1-andriy.shevchenko@linux.intel.com> <63f068fe-13b4-98d1-8e27-faa1bd0bdf23@infradead.org> <20191217194058.GA30852@ravnborg.org> Date: Wed, 18 Dec 2019 12:30:17 +0200 Message-ID: <877e2uylhi.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, 17 Dec 2019, Sam Ravnborg wrote: > On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote: >> On 12/17/19 6:07 AM, Andy Shevchenko wrote: >> > The initial commit followed by the fix didn't take into consideration the case >> > >> > CONFIG_DRM_PANEL=y >> > CONFIG_BACKLIGHT_CLASS_DEVICE=m >> > CONFIG_DRM_I915=y >> > >> > where symbol devm_of_find_backlight() is not reachable from DRM subsystem. >> > Quick fix is to avoid drm_panel_of_backlight() from exporting in such case. >> > >> > Fixes: 907aa265fde6 ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight") >> > Reported-by: Randy Dunlap >> > Cc: Linus Walleij >> > Cc: Sam Ravnborg >> > Cc: Laurent Pinchart >> > Cc: Thierry Reding >> > Cc: Maarten Lankhorst >> > Cc: Sean Paul >> > Cc: David Airlie >> > Cc: Daniel Vetter >> > Cc: Maxime Ripard >> > Cc: dri-devel@lists.freedesktop.org >> > Signed-off-by: Andy Shevchenko >> >> Yes, that fixes the build error. Thanks. >> >> Acked-by: Randy Dunlap # build-tested > > Hi Andy - thanks for fixing this. And thanks Randy for verifying the > fix. > It passed my build test and is now pushed to drm-misc-next. As I wrote in [1], this allows a configuration that builds and links, but is silently broken. You won't get backlight support in drm panel which would be a reasonable expectation with CONFIG_BACKLIGHT_CLASS_DEVICE=m. BR, Jani. [1] http://mid.mail-archive.com/87d0cnynst.fsf@intel.com -- Jani Nikula, Intel Open Source Graphics Center