Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2020-05-18 13:01 Stephen Rothwell
  2020-05-19  8:50 ` Kalle Valo
  0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2020-05-18 13:01 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sean Wang,
	Felix Fietkau, Soul Huang, Lorenzo Bianconi


[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  f8d6379932dd ("mt76: mt7663: fix the usage WoW with net detect support")

Fixes tag

  Fixes: bd39bd2f00c3 ("mt76: mt7663: introduce WoW with net detect support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a72ad451e704 ("mt76: mt7663: introduce WoW with net detect support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2020-05-18 13:01 linux-next: Fixes tag needs some work in the wireless-drivers-next tree Stephen Rothwell
@ 2020-05-19  8:50 ` Kalle Valo
  0 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2020-05-19  8:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List,
	Sean Wang, Felix Fietkau, Soul Huang, Lorenzo Bianconi

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> In commit
>
>   f8d6379932dd ("mt76: mt7663: fix the usage WoW with net detect support")
>
> Fixes tag
>
>   Fixes: bd39bd2f00c3 ("mt76: mt7663: introduce WoW with net detect support")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a72ad451e704 ("mt76: mt7663: introduce WoW with net detect support")

Thanks for the report. I don't think this is bad enough to start
rebasing wireless-drivers-next so I'll leave it as is. But I'll try to
implement some kind of checking of Fixes tags in the future.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2020-04-15  1:06   ` Stephen Rothwell
@ 2020-04-15  4:45     ` Kalle Valo
  0 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2020-04-15  4:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Larry Finger, Wireless, Linux Next Mailing List,
	Linux Kernel Mailing List

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Larry,
>
> On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
>> > 
>> > In commit
>> > 
>> >    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
>> > 
>> > Fixes tag
>> > 
>> >    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
>> > 
>> > has these problem(s):
>> > 
>> >    - Subject does not match target commit subject
>> >      Just use
>> > 	git log -1 --format='Fixes: %h ("%s")'
>> 
>> I do not understand what you want here. The subject describes what was fixed. 
>> The error has been in the driver since it was merged. The Fixes: line is a 
>> description of the commit that introduced the driver file with the error.
>
> The subject I was referring to is the subject quoted in the Fixes tag,
> not the subject of the fixing commit.  So:
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for
> legacy BCM43xx devices")
>
> Its not very important, just a consistency thing - I wouldn't bother
> rebasing just to fix this, just for the future ...

Yeah, I don't normally rebase wireless-drivers-next so this has to be
like this. But hopefully some time in the future I'll end up adding a
check for this in my patchwork script.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2020-04-15  0:36 ` Larry Finger
@ 2020-04-15  1:06   ` Stephen Rothwell
  2020-04-15  4:45     ` Kalle Valo
  0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2020-04-15  1:06 UTC (permalink / raw)
  To: Larry Finger
  Cc: Kalle Valo, Wireless, Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi Larry,

On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> > 
> > In commit
> > 
> >    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
> > 
> > Fixes tag
> > 
> >    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> > 
> > has these problem(s):
> > 
> >    - Subject does not match target commit subject
> >      Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> 
> I do not understand what you want here. The subject describes what was fixed. 
> The error has been in the driver since it was merged. The Fixes: line is a 
> description of the commit that introduced the driver file with the error.

The subject I was referring to is the subject quoted in the Fixes tag,
not the subject of the fixing commit.  So:

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")

Its not very important, just a consistency thing - I wouldn't bother
rebasing just to fix this, just for the future ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2020-04-14 22:08 Stephen Rothwell
@ 2020-04-15  0:36 ` Larry Finger
  2020-04-15  1:06   ` Stephen Rothwell
  0 siblings, 1 reply; 14+ messages in thread
From: Larry Finger @ 2020-04-15  0:36 UTC (permalink / raw)
  To: Stephen Rothwell, Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
> 
> Fixes tag
> 
>    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> 
> has these problem(s):
> 
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 

Stephan,

I do not understand what you want here. The subject describes what was fixed. 
The error has been in the driver since it was merged. The Fixes: line is a 
description of the commit that introduced the driver file with the error.

Larry


^ permalink raw reply	[flat|nested] 14+ messages in thread

* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2020-04-14 22:08 Stephen Rothwell
  2020-04-15  0:36 ` Larry Finger
  0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2020-04-14 22:08 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Larry Finger


[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi all,

In commit

  ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")

Fixes tag

  Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2020-01-27  0:42 Stephen Rothwell
@ 2020-01-29 14:05 ` Kalle Valo
  0 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2020-01-29 14:05 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List,
	Rakesh Pillai

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> n commit
>
>   6ba8b3b6bd77 ("ath10k: Correct the DMA direction for management tx buffers")
>
> Fixes tag
>
>   Fixes: dc405152bb6 ("ath10k: handle mgmt tx completion event")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Doh, I missed that but naturally there's nothing we can do now as the
commit is in Linus' tree. I really should implement some kind of
automatic check to my patchwork script for this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 14+ messages in thread

* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2020-01-27  0:42 Stephen Rothwell
  2020-01-29 14:05 ` Kalle Valo
  0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2020-01-27  0:42 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Rakesh Pillai


[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

n commit

  6ba8b3b6bd77 ("ath10k: Correct the DMA direction for management tx buffers")

Fixes tag

  Fixes: dc405152bb6 ("ath10k: handle mgmt tx completion event")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2019-07-01 21:33 Stephen Rothwell
@ 2019-07-02  4:26 ` dundi
  0 siblings, 0 replies; 14+ messages in thread
From: dundi @ 2019-07-02  4:26 UTC (permalink / raw)
  To: 'Stephen Rothwell', 'Kalle Valo', 'Wireless'
  Cc: 'Linux Next Mailing List', 'Linux Kernel Mailing List'

Hi Stephen,

You are correct, Its
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")

My bad, I added last 12 digits instead of first 12 digits of SHA1.

Regards,
Dundi

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Tuesday, July 2, 2019 3:03 AM
To: Kalle Valo <kvalo@codeaurora.org>; Wireless
<linux-wireless@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
Mailing List <linux-kernel@vger.kernel.org>; Dundi Raviteja
<dundi@codeaurora.org>
Subject: linux-next: Fixes tag needs some work in the wireless-drivers-next
tree

Hi all,

In commit

  c709df58832c ("ath10k: Fix memory leak in qmi")

Fixes tag

  Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990
client")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")

-- 
Cheers,
Stephen Rothwell


^ permalink raw reply	[flat|nested] 14+ messages in thread

* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2019-07-01 21:33 Stephen Rothwell
  2019-07-02  4:26 ` dundi
  0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2019-07-01 21:33 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dundi Raviteja


[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi all,

In commit

  c709df58832c ("ath10k: Fix memory leak in qmi")

Fixes tag

  Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990 client")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
  2019-06-30 21:44 Stephen Rothwell
@ 2019-07-01 10:35 ` Lorenzo Bianconi
  0 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Bianconi @ 2019-07-01 10:35 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Kalle Valo, Wireless, Linux Next Mailing List,
	Linux Kernel Mailing List, Felix Fietkau, Ryder Lee


[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

> Hi all,
> 
> In commit
> 
>   d923cf6bc38a ("mt76: mt7615: fix sparse warnings: warning: cast from restricted __le16")
> 
> Fixes tag
> 
>   Fixes: 3ca0a6f6e9df ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: 516c3e380533 ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")
> 
> In commit
> 
>   eda96044de27 ("mt76: mt7615: fix sparse warnings: incorrect type in assignment (different base types)")
> 
> Fixes tag
> 
>   Fixes: 7339fbc0caa5 ("mt7615: mcu: do not use function pointers whenever possible")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: 1ca8089a55ee ("mt7615: mcu: do not use function pointers whenever possible")
> 
> In commit
> 
>   1a09d9e0e5f0 ("mt76: mt7615: fix incorrect settings in mesh mode")
> 
> Fixes tag
> 
>   Fixes: f072c7ba2150 ("mt76: mt7615: enable support for mesh")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")

Hi Stephen,

I used the hashes from my local git tree that are different from upstream ones,
sorry for the inconvenience. I will pay more attention next time.

Regards,
Lorenzo

> 
> -- 
> Cheers,
> Stephen Rothwell



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2019-06-30 21:44 Stephen Rothwell
  2019-07-01 10:35 ` Lorenzo Bianconi
  0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2019-06-30 21:44 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Lorenzo Bianconi, Felix Fietkau, Ryder Lee


[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

Hi all,

In commit

  d923cf6bc38a ("mt76: mt7615: fix sparse warnings: warning: cast from restricted __le16")

Fixes tag

  Fixes: 3ca0a6f6e9df ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 516c3e380533 ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")

In commit

  eda96044de27 ("mt76: mt7615: fix sparse warnings: incorrect type in assignment (different base types)")

Fixes tag

  Fixes: 7339fbc0caa5 ("mt7615: mcu: do not use function pointers whenever possible")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 1ca8089a55ee ("mt7615: mcu: do not use function pointers whenever possible")

In commit

  1a09d9e0e5f0 ("mt76: mt7615: fix incorrect settings in mesh mode")

Fixes tag

  Fixes: f072c7ba2150 ("mt76: mt7615: enable support for mesh")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2019-05-27 21:48 Stephen Rothwell
  0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2019-05-27 21:48 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Surabhi Vishnoi, Pradeep kumar Chitrapu, Zhi Chen


[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hi all,

In commit

  9280f4fc06f4 ("ath10k: Fix the wrong value of enums for wmi tlv stats id")

Fixes tag

  Fixes: f40a307eb92c ("ath10k: Fill rx duration for each peer in fw_stats for WCN3990)

has these problem(s):

  - Subject has leading but no trailing quotes

In commit

  93ee3d108fc7 ("ath10k: fix incorrect multicast/broadcast rate setting")

Fixes tag

  Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* linux-next: Fixes tag needs some work in the wireless-drivers-next tree
@ 2019-05-01 21:50 Stephen Rothwell
  0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2019-05-01 21:50 UTC (permalink / raw)
  To: Kalle Valo, Wireless
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, kbuild test robot


[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  9c7c756eb066 ("mt76: mt76x02: mt76x02_poll_tx() can be static")

Fixes tag

  Fixes: ec7d2d74760a ("mt76: mt76x02: use napi polling for tx cleanup")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 2ac515a5d74f ("mt76: mt76x02: use napi polling for tx cleanup")

And BTW, we prefer real names on Signed-off-by tags ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 13:01 linux-next: Fixes tag needs some work in the wireless-drivers-next tree Stephen Rothwell
2020-05-19  8:50 ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2020-04-14 22:08 Stephen Rothwell
2020-04-15  0:36 ` Larry Finger
2020-04-15  1:06   ` Stephen Rothwell
2020-04-15  4:45     ` Kalle Valo
2020-01-27  0:42 Stephen Rothwell
2020-01-29 14:05 ` Kalle Valo
2019-07-01 21:33 Stephen Rothwell
2019-07-02  4:26 ` dundi
2019-06-30 21:44 Stephen Rothwell
2019-07-01 10:35 ` Lorenzo Bianconi
2019-05-27 21:48 Stephen Rothwell
2019-05-01 21:50 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git