From: Michael Ellerman <mpe@ellerman.id.au>
To: Michal Hocko <mhocko@kernel.org>
Cc: Joel Stanley <joel@jms.id.au>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
Ralf Baechle <ralf@linux-mips.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org
Subject: Re: linux-next: Tree for Nov 7
Date: Tue, 14 Nov 2017 20:18:04 +1100 [thread overview]
Message-ID: <87a7zpw75f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20171113160637.jhekbdyfpccme3be@dhcp22.suse.cz>
Michal Hocko <mhocko@kernel.org> writes:
> [Sorry for spamming, this one is the last attempt hopefully]
>
> On Mon 13-11-17 16:49:39, Michal Hocko wrote:
>> On Mon 13-11-17 16:16:41, Michal Hocko wrote:
>> > On Mon 13-11-17 13:00:57, Michal Hocko wrote:
>> > [...]
>> > > Yes, I have mentioned that in the previous email but the amount of code
>> > > would be even larger. Basically every arch which reimplements
>> > > arch_get_unmapped_area would have to special case new MAP_FIXED flag to
>> > > do vma lookup.
>> >
>> > It turned out that this might be much more easier than I thought after
>> > all. It seems we can really handle that in the common code. This would
>> > mean that we are exposing a new functionality to the userspace though.
>> > Myabe this would be useful on its own though. Just a quick draft (not
>> > even compile tested) whether this makes sense in general. I would be
>> > worried about unexpected behavior when somebody set other bit without a
>> > good reason and we might fail with ENOMEM for such a call now.
>>
>> Hmm, the bigger problem would be the backward compatibility actually. We
>> would get silent corruptions which is exactly what the flag is trying
>> fix. mmap flags handling really sucks. So I guess we would have to make
>> the flag internal only :/
>
> OK, so this one should take care of the backward compatibility while
> still not touching the arch code
I'm not sure I understand your worries about backward compatibility?
If we add a new mmap flag which is currently unused then what is the
problem? Are you worried about user code that accidentally passes that
flag already?
> diff --git a/include/uapi/asm-generic/mman-common.h b/include/uapi/asm-generic/mman-common.h
> index 203268f9231e..03c518777f83 100644
> --- a/include/uapi/asm-generic/mman-common.h
> +++ b/include/uapi/asm-generic/mman-common.h
> @@ -25,6 +25,8 @@
> # define MAP_UNINITIALIZED 0x0 /* Don't support this flag */
> #endif
>
> +#define MAP_FIXED_SAFE 0x2000000 /* MAP_FIXED which doesn't unmap underlying mapping */
> +
As I said in my other mail I think this should be a modifier to
MAP_FIXED. That way all the existing code that checks for MAP_FIXED (in
the kernel) works exactly as it currently does - like the check Khalid
pointed out.
And I think MAP_NO_CLOBBER would be a better name.
cheers
next prev parent reply other threads:[~2017-11-14 9:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 5:22 linux-next: Tree for Nov 7 Stephen Rothwell
2017-11-07 22:22 ` Joel Stanley
2017-11-08 14:20 ` Michal Hocko
2017-11-10 12:30 ` Michal Hocko
2017-11-12 1:08 ` Joel Stanley
2017-11-13 9:20 ` Michal Hocko
2017-11-13 9:34 ` Russell King - ARM Linux
2017-11-13 9:42 ` Michal Hocko
2017-11-13 11:34 ` Michael Ellerman
2017-11-13 12:00 ` Michal Hocko
2017-11-13 15:16 ` Michal Hocko
2017-11-13 15:48 ` Russell King - ARM Linux
2017-11-13 15:59 ` Michal Hocko
2017-11-13 15:49 ` Michal Hocko
2017-11-13 16:06 ` Michal Hocko
2017-11-13 16:35 ` Khalid Aziz
2017-11-14 7:07 ` Michal Hocko
2017-11-14 9:18 ` Michael Ellerman [this message]
2017-11-14 9:29 ` Michal Hocko
2017-11-14 9:02 ` Michael Ellerman
2017-11-14 8:54 ` Michael Ellerman
2017-11-14 9:04 ` Michal Hocko
2017-11-14 14:52 ` Khalid Aziz
2017-11-13 14:11 ` Michal Hocko
2017-11-13 15:09 ` Russell King - ARM Linux
2017-11-13 15:31 ` Michal Hocko
2017-11-14 0:03 ` Andrew Morton
2017-11-14 0:36 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2023-11-07 1:17 Stephen Rothwell
2022-11-07 3:44 Stephen Rothwell
2019-11-07 8:07 Stephen Rothwell
2018-11-07 3:16 Stephen Rothwell
2013-11-07 7:31 Stephen Rothwell
2012-11-07 5:15 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7zpw75f.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=jcmvbkbc@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=ralf@linux-mips.org \
--cc=sfr@canb.auug.org.au \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).