From: Rusty Russell <rusty@rustcorp.com.au>
To: James Hogan <james.hogan@imgtec.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Al Viro <viro@zeniv.linux.org.uk>, Michal Marek <mmarek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <khali@linux-fr.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Frysinger <vapier@gentoo.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-next@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-mtd@lists.infradead.org
Subject: Re: [RFC -next] linux/linkage.h: fix symbol prefix handling
Date: Fri, 15 Mar 2013 15:07:31 +1030 [thread overview]
Message-ID: <87obelth10.fsf@rustcorp.com.au> (raw)
In-Reply-To: <5141AB3A.2060705@imgtec.com>
James Hogan <james.hogan@imgtec.com> writes:
> On 14/03/13 04:00, Rusty Russell wrote:
>> From: Rusty Russell <rusty@rustcorp.com.au>
>> Subject: CONFIG_SYMBOL_PREFIX: cleanup.
...
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
> Tested-by: James Hogan <james.hogan@imgtec.com> (metag)
Thanks.
> The only other special case of symbol prefixing I'm aware of is in
> scripts/genksyms/genksyms.c. It makes the decision at runtime based
> on the --arch=$ARCH argument, and is the only use of the arch argument:
>
>> if ((strcmp(arch, "h8300") == 0) || (strcmp(arch, "blackfin") == 0) ||
>> (strcmp(arch, "metag") == 0))
>> mod_prefix = "_";
>
> Does the patch below look reasonable in addition to your patch?
> (Note: I'm not sure if genksyms is only used internally or whether
> it's API should be kept stable?).
>
> Thanks
> James
>
> Subject: [PATCH] genksyms: pass symbol-prefix instead of arch
Agreed, I've applied this.
Thanks,
Rusty.
next prev parent reply other threads:[~2013-03-15 5:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 11:44 [RFC -next] linux/linkage.h: fix symbol prefix handling James Hogan
2013-03-08 0:03 ` Rusty Russell
2013-03-08 9:15 ` James Hogan
2013-03-11 6:35 ` Rusty Russell
2013-03-11 12:07 ` Stephen Rothwell
2013-03-12 4:48 ` Rusty Russell
2013-03-12 12:33 ` Stephen Rothwell
2013-03-13 0:00 ` Rusty Russell
2013-03-13 6:31 ` Sam Ravnborg
2013-03-13 9:21 ` James Hogan
2013-03-13 18:15 ` Sam Ravnborg
2013-03-14 4:00 ` Rusty Russell
2013-03-14 10:49 ` James Hogan
2013-03-15 4:37 ` Rusty Russell [this message]
2013-03-12 12:36 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obelth10.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=james.hogan@imgtec.com \
--cc=khali@linux-fr.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mmarek@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).